Issue 4357046: Explicitly use icu namespace

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4357046: Explicitly use icu namespace (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by thakis

Modified:
15 years ago

Reviewers:
Mark Mentovai, eroman, cira1, ager

CC:
v8-dev_googlegroups.com

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Explicitly use icu namespace Chromium builds with U_USING_ICU_NAMESPACE=0, so we need this. Landed in v8 r7487

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
M	src/extensions/experimental/break-iterator.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/extensions/experimental/break-iterator.cc	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/extensions/experimental/i18n-extension.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3

thakis

It would be swell if one of you gentlemen could land this, as I'm not ...

15 years ago (2011-04-03 01:09:54 UTC) #1

Mark Mentovai

v8 changes should be staged at /branches/bleeding_edge, not /trunk. Other than that, this looks fine. ...

15 years ago (2011-04-03 15:36:05 UTC) #2

LGTM, I'll land