Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 4356045: Fixes for a couple brush icon problems (bug #26590) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by nicholasbishop
Modified:
9 years, 2 months ago
Reviewers:
brechtvl, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Here's the original report: http://projects.blender.org/tracker/?func=detail&aid=26590&group_id=9&atid=498 Seems that when a custom brush icon was set, the preview was being regenerated over and over, which prevented other preview jobs from running. Fixed by not calling BKE_icon_changed every time when calling get_brush_icon(). Additionally, changing the brush icon path from a valid image path to empty, or to an invalid path, would leave the original image there. Fixed by the memsetting the preview before returning.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
source/blender/editors/render/render_preview.c View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2
nicholasbishop
10 years, 1 month ago (2011-04-03 15:40:49 UTC) #1
brechtvl
10 years ago (2011-04-15 11:54:40 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b