Issue 4356045: Fixes for a couple brush icon problems (bug #26590)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4356045: Fixes for a couple brush icon problems (bug #26590) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by nicholasbishop

Modified:
12 years, 1 month ago

Reviewers:
brechtvl, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

Here's the original report: http://projects.blender.org/tracker/?func=detail&aid=26590&group_id=9&atid=498 Seems that when a custom brush icon was set, the preview was being regenerated over and over, which prevented other preview jobs from running. Fixed by not calling BKE_icon_changed every time when calling get_brush_icon(). Additionally, changing the brush icon path from a valid image path to empty, or to an invalid path, would leave the original image there. Fixed by the memsetting the preview before returning.

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
		source/blender/editors/render/render_preview.c	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages