code review 4353043: update go tree for reflect changes

update go tree for reflect changes

[rsc, 2011-04-04 21:15:37]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[rsc, 2011-04-04 21:16:28]

This is mechanically generated by running gofix and then
applying the patch below.  There are some obvious improvements
that could be made by hand to the code.  I will do them in a
separate CL after this is submitted.


--- src/pkg/fmt/print.go	2011-04-01 15:34:30.000000000 -0400
+++ src/pkg/fmt/print.go	2011-04-01 15:36:36.000000000 -0400
@@ -278,11 +278,6 @@
 	return
 }

-// Reflection values like reflect.FuncValue implement this method. We
use it for %p.
-type uintptrGetter interface {
-	Get() uintptr
-}
-
 func (p *pp) unknownType(v interface{}) {
 	if v == nil {
 		p.buf.Write(nilAngleBytes)
@@ -523,7 +518,7 @@
 	var u uintptr
 	switch value.Kind() {
 	case reflect.Chan, reflect.Func, reflect.Map, reflect.Ptr,
reflect.Slice, reflect.UnsafePointer:
-		u = value.(uintptrGetter).Get()
+		u = value.Pointer()
 	default:
 		p.badVerb(verb, field)
 		return
--- src/pkg/json/encode.go	2011-04-01 15:39:55.000000000 -0400
+++ src/pkg/json/encode.go	2011-04-01 15:39:58.000000000 -0400
@@ -296,7 +296,7 @@
 		}
 		e.WriteByte(']')

-	case interfaceOrPtrValue:
+	case reflect.Interface, reflect.Ptr:
 		if v.IsNil() {
 			e.WriteString("null")
 			return
--- src/pkg/go/ast/print.go	2011-04-01 15:48:48.000000000 -0400
+++ src/pkg/go/ast/print.go	2011-04-01 15:55:32.000000000 -0400
@@ -21,11 +21,12 @@

 // NotNilFilter returns true for field values that are not nil;
 // it returns false otherwise.
-func NotNilFilter(_ string, value reflect.Value) bool {
-	v, ok := value.(interface {
-		IsNil() bool
-	})
-	return !ok || !v.IsNil()
+func NotNilFilter(_ string, v reflect.Value) bool {
+	switch v.Kind() {
+	case reflect.Chan, reflect.Func, reflect.Interface, reflect.Map,
reflect.Ptr, reflect.Slice:
+		return !v.IsNil()
+	}
+	return false
 }

[r, 2011-04-04 23:41:56]

LGTM

[rsc, 2011-04-08 16:28:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=61c414d8a0a9 ***

update go tree for reflect changes

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4353043