Fix ChangePhoto method in gdata.contacts.client.ContactsClient.

[alainv, 2011-04-22 21:11:55]

Ping?

[Ali Afshar, 2011-04-24 14:25:04]

In principal, LGTM for this change, but I don't know enough about the API to
know the details of GetPhotoEditLink vs GetPhotoLink.

http://codereview.appspot.com/4350042/diff/1/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4350042/diff/1/src/gdata/contacts/client.py#new...
src/gdata/contacts/client.py:245: content_length=None, auth_token=None,
**kwargs):
In principal, LGTM for this change, but I don't know enough about the API to
know the details of GetPhotoEditLink vs GetPhotoLink.

http://codereview.appspot.com/4350042/diff/1/src/gdata/contacts/client.py#new...
src/gdata/contacts/client.py:282: return self.Put(uri=url, data=payload,
auth_token=auth_token, **kwargs)
Could/should we use the local variable "uri" instead of "url" and have uri=uri
in the call to Put? I am not convinced, but uri=uri is just a bit weird.

[Ali Afshar, 2011-04-24 14:27:25]

On 2011/04/24 14:25:04, Ali Afshar wrote:

> in the call to Put? I am not convinced, but uri=uri is just a bit weird.

I mean "uri=url" is a bit weird.

[Ali Afshar, 2011-04-24 14:27:45]

On 2011/04/24 14:25:04, Ali Afshar wrote:

> in the call to Put? I am not convinced, but uri=uri is just a bit weird.

I mean "uri=url" is a bit weird.

[alainv, 2011-04-25 15:58:19]

http://codereview.appspot.com/4350042/diff/1/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4350042/diff/1/src/gdata/contacts/client.py#new...
src/gdata/contacts/client.py:282: return self.Put(uri=url, data=payload,
auth_token=auth_token, **kwargs)
On 2011/04/24 14:25:04, Ali Afshar wrote:
> Could/should we use the local variable "uri" instead of "url" and have uri=uri
> in the call to Put? I am not convinced, but uri=uri is just a bit weird.

Not sure either so I followed your feedback :)