code review 4339054: gotest: fixes for [^.]_test file pattern

gotest: fixes for [^.]_test file pattern

[peterGo, 2011-04-05 17:37:29]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-04-05 17:46:36]

http://codereview.appspot.com/4339054/diff/2002/src/cmd/gotest/doc.go
File src/cmd/gotest/doc.go (right):

http://codereview.appspot.com/4339054/diff/2002/src/cmd/gotest/doc.go#newcode11
src/cmd/gotest/doc.go:11: directory, along with any files named [^.]*_test.go. 
Functions in the
along with any files whose names match the pattern "[^.]*_test.go".

you may need to reflow the paragraph.

http://codereview.appspot.com/4339054/diff/2002/src/cmd/gotest/doc.go#newcode44
src/cmd/gotest/doc.go:44: -file a.go Use the tests in the source file a.go
instead of [^.]*_test.go.
that reads clumsily.
Use only the tests in the source file a.go. Multiple -file flags may be
provided.

http://codereview.appspot.com/4339054/diff/2002/src/cmd/gotest/gotest.go
File src/cmd/gotest/gotest.go (right):

http://codereview.appspot.com/4339054/diff/2002/src/cmd/gotest/gotest.go#newc...
src/cmd/gotest/gotest.go:148: // If gotest has no arguments, it scans the
current directory for [^.]*_test.go files.
// If gotest has no arguments, it scans for file names matching "[^.]*_test.go".

[peterGo, 2011-04-05 18:19:12]

Hello rsc, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-04-05 18:27:16]

http://codereview.appspot.com/4339054/diff/3005/src/cmd/gotest/doc.go
File src/cmd/gotest/doc.go (right):

http://codereview.appspot.com/4339054/diff/3005/src/cmd/gotest/doc.go#newcode45
src/cmd/gotest/doc.go:45: -file a.go Use only the tests in the source file a.go.
Multiple -file flags may be provided.
how about a line break between the sentences?

[peterGo, 2011-04-05 18:32:26]

Hello rsc, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-04-05 18:34:08]

LGTM

[r, 2011-04-05 18:49:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=63feffdecc1b ***

gotest: fixes for [^.]_test file pattern

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/4339054

Committer: Rob Pike <r@golang.org>