Issue 4339053: Allows beam collision to be turned off for certain interfaces.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4339053: Allows beam collision to be turned off for certain interfaces. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by MikeSol

Modified:
15 years, 1 month ago

Reviewers:
mike, Graham Percival (old account), hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Allows beam collision to be turned off for certain interfaces.

Patch Set 1 #

Total comments: 3

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -2 lines)			Patch
A	input/regression/beam-collision-off.ly	View	1 chunk	+32 lines, -0 lines	1 comment	Download
M	lily/beam.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lily/beam-collision-engraver.cc	View	2 chunks	+21 lines, -1 line	1 comment	Download
M	scm/define-grob-properties.scm	View	2 chunks	+2 lines, -1 line	1 comment	Download
M	scm/define-grobs.scm	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

MikeSol

After some discussion on devel, it seems like a suitable thing to do in the ...

15 years, 1 month ago (2011-04-05 11:17:01 UTC) #1

hanwenn

LGTM http://codereview.appspot.com/4339053/diff/1/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4339053/diff/1/lily/beam-collision-engraver.cc#newcode60 lily/beam-collision-engraver.cc:60: break; you can do for .. if (covered->has_interface(..)) ...

15 years, 1 month ago (2011-04-05 19:47:42 UTC) #2

Graham Percival (old account)

LGTM, passes regtests. http://codereview.appspot.com/4339053/diff/1/input/regression/beam-collision-off.ly File input/regression/beam-collision-off.ly (right): http://codereview.appspot.com/4339053/diff/1/input/regression/beam-collision-off.ly#newcode8 input/regression/beam-collision-off.ly:8: c8 [ des' ] totally minor ...

15 years, 1 month ago (2011-04-05 20:00:10 UTC) #3

mike_apollinemike.com

15 years, 1 month ago (2011-04-05 21:04:29 UTC) #4

On Apr 5, 2011, at 4:00 PM, percival.music.ca@gmail.com wrote:

> LGTM, passes regtests.
> 
> 
>
http://codereview.appspot.com/4339053/diff/1/input/regression/beam-collision-...
> File input/regression/beam-collision-off.ly (right):
> 
>
http://codereview.appspot.com/4339053/diff/1/input/regression/beam-collision-...
> input/regression/beam-collision-off.ly:8: c8 [ des' ]
> totally minor issue: could these be indented 2 spaces?
> 
> http://codereview.appspot.com/4339053/

Thanks for your comments!

Pushed.
a7ce690984178ad48c0ed2cafed0014d88a7a16b

Cheers,
Mike

Expand All Messages | Collapse All Messages