Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 43380043: Improve unexpected fields handling.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by frankban
Modified:
10 years, 4 months ago
Reviewers:
matthew.scott, mp+199270
Visibility:
Public.

Description

Improve unexpected fields handling. Implement the UnexpectedField type. This is used to handle unexpected key/value pairs found in the environments.yaml file. The user will be able to get rid of those fields just deleting their values from in the interactive session. Tests: `make check`. No QA. https://code.launchpad.net/~frankban/juju-quickstart/improve-unexpected-fields/+merge/199270 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Improve unexpected fields handling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/models/envs.py View 1 1 chunk +2 lines, -3 lines 0 comments Download
M quickstart/models/fields.py View 1 chunk +41 lines, -0 lines 0 comments Download
M quickstart/tests/models/test_envs.py View 1 2 chunks +25 lines, -0 lines 0 comments Download
M quickstart/tests/models/test_fields.py View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 4 months ago (2013-12-17 11:57:13 UTC) #1
matthew.scott
LGTM, thanks!
10 years, 4 months ago (2013-12-17 16:21:17 UTC) #2
frankban
*** Submitted: Improve unexpected fields handling. Implement the UnexpectedField type. This is used to handle ...
10 years, 4 months ago (2013-12-17 16:27:55 UTC) #3
frankban
10 years, 4 months ago (2013-12-17 16:29:26 UTC) #4
Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b