Add error message for InvalidSecondFactor in upload-diffs.py

[Vic Fryzel, 2011-03-31 15:34:23]

http://codereview.appspot.com/4324045/diff/1/upload-diffs.py
File upload-diffs.py (right):

http://codereview.appspot.com/4324045/diff/1/upload-diffs.py#newcode290
upload-diffs.py:290: print >>sys.stderr, "Bad authentication (%s)." % e.info
May as well mention a specific 2-factor message if you're catching at this level
of detail.

[proppy.gmail, 2011-03-31 15:48:50]

Added more specific error message for InvalidSecondFactor

http://codereview.appspot.com/4324045/diff/1/upload-diffs.py
File upload-diffs.py (right):

http://codereview.appspot.com/4324045/diff/1/upload-diffs.py#newcode290
upload-diffs.py:290: print >>sys.stderr, "Bad authentication (%s)." % e.info
On 2011/03/31 15:34:23, Vic Fryzel wrote:
> May as well mention a specific 2-factor message if you're catching at this
level
> of detail.

Done.

[jcgregorio, 2011-03-31 19:27:00]

Upload-diffs.py is just a copy of the Rietveld upload.py script with some
changes to the default parameters. If this is a useful change it should probably
be done upstream to upload.py. It may also already be done as I don't believe
upload-diffs.py has been synced to upload.py in a very long time.

On 2011/03/31 15:48:50, proppyy wrote:
> Added more specific error message for InvalidSecondFactor
> 
> http://codereview.appspot.com/4324045/diff/1/upload-diffs.py
> File upload-diffs.py (right):
> 
> http://codereview.appspot.com/4324045/diff/1/upload-diffs.py#newcode290
> upload-diffs.py:290: print >>sys.stderr, "Bad authentication (%s)." % e.info
> On 2011/03/31 15:34:23, Vic Fryzel wrote:
> > May as well mention a specific 2-factor message if you're catching at this
> level
> > of detail.
> 
> Done.

[proppy, 2011-03-31 19:44:46]

Done.
http://code.google.com/p/rietveld/issues/detail?id=289

On 2011/03/31 19:27:00, jcgregorio wrote:
> Upload-diffs.py is just a copy of the Rietveld upload.py script with some
> changes to the default parameters. If this is a useful change it should
probably
> be done upstream to upload.py. It may also already be done as I don't believe
> upload-diffs.py has been synced to upload.py in a very long time.
> 
> On 2011/03/31 15:48:50, proppyy wrote:
> > Added more specific error message for InvalidSecondFactor
> > 
> > http://codereview.appspot.com/4324045/diff/1/upload-diffs.py
> > File upload-diffs.py (right):
> > 
> > http://codereview.appspot.com/4324045/diff/1/upload-diffs.py#newcode290
> > upload-diffs.py:290: print >>sys.stderr, "Bad authentication (%s)." % e.info
> > On 2011/03/31 15:34:23, Vic Fryzel wrote:
> > > May as well mention a specific 2-factor message if you're catching at this
> > level
> > > of detail.
> > 
> > Done.