code review 43210043: time: fix test error in Chinese edition of Windows

time: fix test error in Chinese edition of Windows
On the Chinese Windows XP system that I'm using, GetTimeZoneInformation returns a struct containing "中国标准时间" (China Standard Time in Chinese) in both StandardName and DaylightName (which is correct, because China does not use DST). However, in registry, under key HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\China Standard Time, the key Std and Dlt contain "中国标准时间" (China Standard Time in Chinese) and "中国夏季时间" (China Summer Time in Chinese) respectively. This means that time.toEnglishName() cannot determine the abbreviation for the local timezone (CST) and causes test failures (time.Local is empty)

[minux1, 2013-12-17 06:48:57]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-12-17 06:50:00]

LGTM
 On Dec 16, 2013 10:49 PM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> time: fix test error in Chinese edition of Windows
> On the Chinese Windows XP system that I'm using, GetTimeZoneInformation
> returns a struct containing "中国标准时间" (China Standard Time in Chinese) in
> both StandardName and DaylightName (which is correct, because China does
> not use DST). However, in registry, under key
> HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\China
> Standard Time, the key Std and Dlt contain "中国标准时间" (China Standard Time
> in Chinese) and "中国夏季时间" (China Summer Time in Chinese) respectively.
> This means that time.toEnglishName() cannot determine the abbreviation
> for the local timezone (CST) and causes test failures (time.Local is
> empty)
> I'm not sure this is the correct fix, suggestions welcome.
>
> Please review this at https://codereview.appspot.com/43210043/
>
> Affected files (+1, -1 lines):
>   M src/pkg/time/zoneinfo_windows.go
>
>
> Index: src/pkg/time/zoneinfo_windows.go
> ===================================================================
> --- a/src/pkg/time/zoneinfo_windows.go
> +++ b/src/pkg/time/zoneinfo_windows.go
> @@ -54,7 +54,7 @@
>         if err != nil {
>                 return false, err
>         }
> -       if s != dstname {
> +       if s != dstname && dstname != stdname {
>                 return false, nil
>         }
>         return true, nil
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[minux1, 2013-12-17 07:43:20]

*** Submitted as https://code.google.com/p/go/source/detail?r=ba905026f14d ***

time: fix test error in Chinese edition of Windows
On the Chinese Windows XP system that I'm using, GetTimeZoneInformation returns
a struct containing "中国标准时间" (China Standard Time in Chinese) in both
StandardName and DaylightName (which is correct, because China does not use
DST). However, in registry, under key HKLM\SOFTWARE\Microsoft\Windows
NT\CurrentVersion\Time Zones\China Standard Time, the key Std and Dlt contain
"中国标准时间" (China Standard Time in Chinese) and "中国夏季时间" (China Summer Time in
Chinese) respectively. This means that time.toEnglishName() cannot determine the
abbreviation for the local timezone (CST) and causes test failures (time.Local
is empty)

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/43210043

[dvyukov, 2013-12-17 08:09:29]

I suspect all our builders are down with:
2013/12/17 12:05:57 json unmarshal ``: unexpected end of JSON input
2013/12/17 12:05:57 unexpected end of JSON input


On Tue, Dec 17, 2013 at 11:43 AM,  <minux.ma@gmail.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=ba905026f14d ***
>
>
> time: fix test error in Chinese edition of Windows
> On the Chinese Windows XP system that I'm using, GetTimeZoneInformation
> returns a struct containing "中国标准时间" (China Standard Time in Chinese) in
> both StandardName and DaylightName (which is correct, because China does
> not use DST). However, in registry, under key
> HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\China
> Standard Time, the key Std and Dlt contain "中国标准时间" (China Standard Time
> in Chinese) and "中国夏季时间" (China Summer Time in Chinese) respectively.
> This means that time.toEnglishName() cannot determine the abbreviation
> for the local timezone (CST) and causes test failures (time.Local is
> empty)
>
> R=golang-dev, bradfitz
> CC=golang-dev
> https://codereview.appspot.com/43210043
>
>
> https://codereview.appspot.com/43210043/
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[minux1, 2013-12-17 08:21:11]

On Dec 17, 2013 3:09 AM, "Dmitry Vyukov" <dvyukov@google.com> wrote:
>
> I suspect all our builders are down with:
> 2013/12/17 12:05:57 json unmarshal ``: unexpected end of JSON input
> 2013/12/17 12:05:57 unexpected end of JSON input
sorry about that.
however this does gives us perfect motivation to deploy your fix to the
dashboard. ;-)

[brainman, 2013-12-17 23:25:39]

This whole thing is completely broken. :-(

Alex