code review 43190044: Limit buffering during tokenization.

Limit buffering during tokenization.

This is optional. By default, buffering is unlimited.

Fixes issue 7053.

[piatek, 2014-01-02 21:08:49]

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net/

[bradfitz, 2014-01-03 17:41:37]

https://codereview.appspot.com/43190044/diff/80001/html/token.go
File html/token.go (right):

https://codereview.appspot.com/43190044/diff/80001/html/token.go#newcode1188
html/token.go:1188: func NewTokenizerMaxBuffer(r io.Reader, maxBuffer int) (z
*Tokenizer) {
Let's make this a method on Tokenizer instead of a new constructor.  I would
even be fine with no method and just exporting the MaxBuf field of Tokenizer
too, but there aren't other public things on that struct.

Also, style nit: don't name this return parameter.  It's documentation noise for
no gain.  Then ditch the naked return.

But let's make it a method anyway.   (and a method returning nothing, not the
receiver... Go doesn't really chain)

[piatek, 2014-01-03 18:00:59]

https://codereview.appspot.com/43190044/diff/80001/html/token.go
File html/token.go (right):

https://codereview.appspot.com/43190044/diff/80001/html/token.go#newcode1188
html/token.go:1188: func NewTokenizerMaxBuffer(r io.Reader, maxBuffer int) (z
*Tokenizer) {
On 2014/01/03 17:41:37, bradfitz wrote:
> Let's make this a method on Tokenizer instead of a new constructor.  I would
> even be fine with no method and just exporting the MaxBuf field of Tokenizer
> too, but there aren't other public things on that struct.
> 
> Also, style nit: don't name this return parameter.  It's documentation noise
for
> no gain.  Then ditch the naked return.
> 
> But let's make it a method anyway.   (and a method returning nothing, not the
> receiver... Go doesn't really chain)

Done.

[bradfitz, 2014-01-03 21:15:26]

LGTM

[bradfitz, 2014-01-03 21:16:57]

*** Submitted as
https://code.google.com/p/go/source/detail?r=241993936603&repo=net ***

html: limit buffering during tokenization.

This is optional. By default, buffering is unlimited.

Fixes issue 7053

R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/43190044

Committer: Brad Fitzpatrick <bradfitz@golang.org>