Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(654)

Issue 4314051: Joomla master .htaccess - differences 2.4.6 - 3.2.f (r)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by g1smd
Modified:
13 years ago
Reviewers:
nikosdion
Base URL:
http://joomla-master-htaccess.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Based on the version 2.3 code originally found at: http://snipt.net/nikosdion/the-master-htaccess/ and now listed at: http://code.google.com/p/joomla-master-htaccess/source/browse/trunk/joomla-master-htaccess.txt?spec=svn2&r=2 The original file contains a number of syntax errors, several rules that can never work, and a number of expressions that can be more efficiently coded. Bugs and enhancements originally discussed at: http://forum.joomla.org/viewtopic.php?f=432&t=549841 Discussion also at: http://snipt.net/nikosdion/the-master-htaccess/ The new 2.4.6 proposed file: http://snipt.net/g1smd/joomla-master-htaccess-file-proposed-v24-2011-04-09/ \[404]\ or at: http://code.google.com/p/joomla-master-htaccess/source/browse/trunk/joomla-master-htaccess.txt?spec=svn4&r=22 NOTE: this is not now the latest version of the file. Continued in: http://codereview.appspot.com/4430062/

Patch Set 1 : Joomla master .htaccess - differences 2.4.6 - 3.2.f #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -45 lines) Patch
joomla-master-htaccess.txt View 16 chunks +33 lines, -45 lines 12 comments Download

Messages

Total messages: 1
g1smd
13 years ago (2011-04-24 09:06:13 UTC) #1
http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt
File joomla-master-htaccess.txt (left):

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ol...
joomla-master-htaccess.txt:83: #  Uncomment following line if your webserver's
URL
Remove spaces.

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ol...
joomla-master-htaccess.txt:84: #  is not directly related to physical file
paths.
Remove spaces.

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ol...
joomla-master-htaccess.txt:85: #  Update Your Joomla! Directory (just / for
root)
Remove spaces.

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ol...
joomla-master-htaccess.txt:112: ## Suit to taste.
Note is no longer needed.

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ol...
joomla-master-htaccess.txt:284: ## These are sample exceptions to the Advanced
Server Protection 3.0
The code is much altered since August 2010. The 3.0 tag is now incorrect.

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ol...
joomla-master-htaccess.txt:318: # Advanced server protection, version 2.0 -
August 2010
The code is much altered since August 2010. The 2.0 tag is now incorrect.

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ol...
joomla-master-htaccess.txt:343: RewriteCond %{QUERY_STRING}
\=PHP[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12} [NC]
This is a hexadecimal match: [0-9a-f] [NC].

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ol...
joomla-master-htaccess.txt:415: RewriteCond %{REQUEST_URI}
/component/|(/[^.]*|\.(php|html?|feed|pdf|raw|ini|zip|json|file|vcf))$ [NC]
vcf is after pdf and before raw in the official files.

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt
File joomla-master-htaccess.txt (right):

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ne...
joomla-master-htaccess.txt:220: ########## End - Redirect (www.)olddomain.com to
www.example.com
Add (www.) to olddomain.com

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ne...
joomla-master-htaccess.txt:330: RewriteCond %{QUERY_STRING}
\=PHP[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12} [NC]
This is a hexadecimal match: [0-9a-f] [NC].

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ne...
joomla-master-htaccess.txt:365: ## Disallow access to htaccess.txt,
configuration.php, configuration.php-dist and php.ini
and php.ini

http://codereview.appspot.com/4314051/diff/1001/joomla-master-htaccess.txt#ne...
joomla-master-htaccess.txt:403: RewriteCond %{REQUEST_URI}
/component/|(/[^.]*|\.(php|html?|feed|pdf|vcf|raw|ini|zip|json|file))$ [NC]
vcf is after pdf and before raw in the official files.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b