code review 43130043: cmd/ld: maintain correct headstring needed by windows port.

cmd/ld: maintain correct headstring needed by windows port.
Fixes build for go_bootstrap.
Fixes issue 6971.

[minux1, 2013-12-17 03:13:24]

Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[brainman, 2013-12-17 03:18:03]

LGTM

Thank you. There are still many broken tests. I have disabled them all here
https://codereview.appspot.com/43100043/.

Alex

[brainman, 2013-12-17 03:18:59]

Also, probably, want to close issue 6971.

Alex

[mattn, 2013-12-17 03:26:14]

Do you have plan to separate to Hwindows/Hwindowsgui, don't you?

[minux1, 2013-12-17 03:45:30]

On Dec 16, 2013 10:26 PM, <mattn.jp@gmail.com> wrote:
> Do you have plan to separate to Hwindows/Hwindowsgui, don't you?
they are separate. they just share the same HEADTYPE (Hwindows).

[minux1, 2013-12-17 03:47:29]

On Dec 16, 2013 10:18 PM, <alex.brainman@gmail.com> wrote:
> Also, probably, want to close issue 6971.
Thanks. I added "fixes issue 6971" to the description.

[mattn, 2013-12-17 03:49:23]

Then, just to remove "headstring"?

On Tuesday, December 17, 2013 12:45:29 PM UTC+9, minux wrote:
>
>
> On Dec 16, 2013 10:26 PM, <matt...@gmail.com <javascript:>> wrote:
> > Do you have plan to separate to Hwindows/Hwindowsgui, don't you?
> they are separate. they just share the same HEADTYPE (Hwindows).
>  

[mattn, 2013-12-17 03:50:52]

Ah, I understand you are trying to do. LGTM

[rsc, 2013-12-17 12:35:31]

LGTM

[rsc, 2013-12-17 12:36:03]

*** Submitted as https://code.google.com/p/go/source/detail?r=fe20c205df9f ***

cmd/ld: maintain correct headstring needed by windows port.
Fixes build for go_bootstrap.
Fixes issue 6971.

R=alex.brainman, mattn.jp, rsc
CC=golang-dev
https://codereview.appspot.com/43130043

Committer: Russ Cox <rsc@golang.org>

[0intro, 2013-12-17 13:07:02]

https://codereview.appspot.com/43130043/diff/40001/src/cmd/ld/pobj.c
File src/cmd/ld/pobj.c (right):

https://codereview.appspot.com/43130043/diff/40001/src/cmd/ld/pobj.c#newcode141
src/cmd/ld/pobj.c:141: if (headstring == NULL)
NULL should be nil

It broke build on Plan 9.