Issue 43120044: code review 43120044: runtime/cgo: include <signal.h> to fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43120044: code review 43120044: runtime/cgo: include <signal.h> to fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by iant

Modified:
11 years, 6 months ago

Reviewers:
dave

CC:
dave_cheney.net, golang-codereviews

Visibility:
Public.

Description

runtime/cgo: include <signal.h> to fix build

Patch Set 2 : diff -r 15deca59be01 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/cgo/gcc_freebsd_arm.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/runtime/cgo/gcc_linux_arm.c	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-12-24 16:23:45 UTC) #1

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=176779a4ebed *** runtime/cgo: include <signal.h> to fix build R=golang-codereviews TBR=dfc CC=golang-codereviews https://codereview.appspot.com/43120044

11 years, 6 months ago (2013-12-24 16:24:36 UTC) #2

dave_cheney.net

11 years, 6 months ago (2013-12-24 21:51:38 UTC) #3

LGTM.

On Wed, Dec 25, 2013 at 3:24 AM,  <iant@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=176779a4ebed ***
>
>
> runtime/cgo: include <signal.h> to fix build
>
> R=golang-codereviews
> TBR=dfc
> CC=golang-codereviews
> https://codereview.appspot.com/43120044
>
>
> https://codereview.appspot.com/43120044/

Expand All Messages | Collapse All Messages