Issue 4308046: Define U_USING_ICU_NAMESPACE=0 for all projects using ICU

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4308046: Define U_USING_ICU_NAMESPACE=0 for all projects using ICU

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by thakis

Modified:
13 years ago

Reviewers:
Mark Mentovai, jshin

Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/icu46/

Visibility:
Public.

Description

Depends on http://codereview.appspot.com/4357046/ landing first.

Patch Set 2 : address comments #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	icu.gyp	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

http://codereview.appspot.com/4308046/diff/1/icu.gyp File icu.gyp (right): http://codereview.appspot.com/4308046/diff/1/icu.gyp#newcode16 icu.gyp:16: 'direct_dependent_settings': { You can actually just pull this out ...

13 years ago (2011-04-03 20:56:26 UTC) #2

thakis

13 years ago (2011-04-03 22:28:53 UTC) #3

LGTM

Expand All Messages | Collapse All Messages