Issue 43080043: code review 43080043: cmd/go: set GOROOT when testing "go install cmd/fix"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43080043: code review 43080043: cmd/go: set GOROOT when testing "go install cmd/fix" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by adg

Modified:
11 years, 7 months ago

Reviewers:
iant

CC:
golang-dev, dave_cheney.net, iant

Visibility:
Public.

Description

cmd/go: set GOROOT when testing "go install cmd/fix" This particular test would never pass unless you had GOROOT set in your environment. This changes makes the test use the baked-in GOROOT, as it does with GOOS and GOARCH.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 5118124bb019 https://code.google.com/p/go #

Patch Set 3 : diff -r 27a98ee561a0 https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/cmd/go/test.bash	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-12-17 00:54:21 UTC) #1

dave_cheney.net

https://codereview.appspot.com/43080043/diff/1/src/cmd/go/test.bash File src/cmd/go/test.bash (right): https://codereview.appspot.com/43080043/diff/1/src/cmd/go/test.bash#newcode39 src/cmd/go/test.bash:39: unset GOPATH should GOROOT be unset here as an ...

11 years, 7 months ago (2013-12-17 00:57:48 UTC) #2

adg

On 17 December 2013 11:57, <dave@cheney.net> wrote: > should GOROOT be unset here as an ...

11 years, 7 months ago (2013-12-17 01:03:19 UTC) #3

adg

11 years, 7 months ago (2013-12-17 01:18:06 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=5fcb7f36d5cd ***

cmd/go: set GOROOT when testing "go install cmd/fix"

This particular test would never pass unless you had GOROOT set in your
environment. This changes makes the test use the baked-in GOROOT, as it
does with GOOS and GOARCH.

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/43080043

Expand All Messages | Collapse All Messages