Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(316)

Issue 4306048: fix playground clock demo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by felix8a
Modified:
15 years, 4 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

the clock demo works fine, but if you run something after running the clock demo, the js console starts spitting out errors every second, because the clock demo set an interval handler that's still firing every second. afaict, there's no security implication to this leak, since the interval handler is as sandboxed as it would be if it were just one gadget on a page full of gadgets, but the unintentional resource leak is annoying, and maybe caja should automatically cancel timers when a gadget is unloaded. in the meantime, this change makes the clock demo cancel the interval handler when it notices it's been unloaded.

Patch Set 1 #

Patch Set 2 : fix playground clock demo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/com/google/caja/demos/playground/examples/clock.html View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 2
felix8a
15 years, 4 months ago (2011-03-23 21:07:38 UTC) #1
Jasvir
15 years, 4 months ago (2011-03-23 21:28:08 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b