Issue 4305041: Small changes to get Photon working

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4305041: Small changes to get Photon working (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by ihab.awad

Modified:
15 years, 4 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Small changes to keep Photon working and ensure it works properly when invoked as "http://localhost:8080/photon/container/" on the server started by the "ant runserver" target.

Patch Set 2 : Small changes to get Photon working #

Total comments: 2

Patch Set 3 : Small changes to get Photon working #

Patch Set 4 : Small changes to get Photon working #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -15 lines)			Patch
M	src/com/google/caja/demos/photon/container/main.js	View	1 2	4 chunks	+14 lines, -11 lines	0 comments	Download
M	src/com/google/caja/demos/photon/container/photon.js	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/caja.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/CompileHtmlStage.java	View		3 chunks	+8 lines, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/es53-test-basic-functions-cajoled.html	View	1 2 3	3 chunks	+15 lines, -1 line	0 comments	Download
A	tests/com/google/caja/plugin/jsmodules/test.js	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jasvir

LGTM http://codereview.appspot.com/4305041/diff/3001/src/com/google/caja/demos/photon/container/main.js File src/com/google/caja/demos/photon/container/main.js (right): http://codereview.appspot.com/4305041/diff/3001/src/com/google/caja/demos/photon/container/main.js#newcode56 src/com/google/caja/demos/photon/container/main.js:56: // is getting served from. This makes our ...

15 years, 4 months ago (2011-03-21 21:37:54 UTC) #2

ihab.awad

http://codereview.appspot.com/4305041/diff/3001/src/com/google/caja/demos/photon/container/main.js File src/com/google/caja/demos/photon/container/main.js (right): http://codereview.appspot.com/4305041/diff/3001/src/com/google/caja/demos/photon/container/main.js#newcode56 src/com/google/caja/demos/photon/container/main.js:56: // is getting served from. This makes our Caja ...

15 years, 4 months ago (2011-03-21 22:06:42 UTC) #3

@4401

Expand All Messages | Collapse All Messages