Issue 43010044: code review 43010044: misc/vim: use shiftwidth() instead of &sw if available.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43010044: code review 43010044: misc/vim: use shiftwidth() instead of &sw if available. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by minux1

Modified:
11 years, 4 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

misc/vim: use shiftwidth() instead of &sw if available. Fixes issue 6841.

Patch Set 2 : diff -r 5118124bb019 https://code.google.com/p/go #

Patch Set 3 : diff -r 5118124bb019 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 5118124bb019 https://code.google.com/p/go #

Patch Set 5 : diff -r 5118124bb019 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	misc/vim/indent/go.vim	View	1 2 3	3 chunks	+16 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2013-12-16 22:53:59 UTC) #1

dsymonds

LGTM Thanks. https://codereview.appspot.com/43010044/diff/40001/misc/vim/indent/go.vim File misc/vim/indent/go.vim (right): https://codereview.appspot.com/43010044/diff/40001/misc/vim/indent/go.vim#newcode27 misc/vim/indent/go.vim:27: if exists('*shiftwidth') add a comment above here. ...

11 years, 4 months ago (2013-12-17 00:39:31 UTC) #2

dsymonds

LGTM sorry, one more little nit. https://codereview.appspot.com/43010044/diff/40001/misc/vim/indent/go.vim File misc/vim/indent/go.vim (right): https://codereview.appspot.com/43010044/diff/40001/misc/vim/indent/go.vim#newcode33 misc/vim/indent/go.vim:33: return &sw I'd ...

11 years, 4 months ago (2013-12-17 00:41:27 UTC) #3

minux1

11 years, 4 months ago (2013-12-17 01:05:57 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=27a98ee561a0 ***

misc/vim: use shiftwidth() instead of &sw if available.
Fixes issue 6841.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/43010044

Expand All Messages | Collapse All Messages