Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(307)

Issue 4298056: fix unboxed demo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by felix8a
Modified:
15 years, 4 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* image uris were still referring to thinkfu. this makes image uris relative to location of playground, which requires loosening the uri policy to allow relative links. * "restart" was broken. model.board is assigned to an object at model creation time, which is the same as the local var 'board'. model.reset() reassigns local var 'board' to a new object, but model.board is still the old object. so internal to model we have a new board, but external users of model still see the old board.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M src/com/google/caja/demos/playground/examples/unboxed/index.html View 8 chunks +19 lines, -21 lines 2 comments Download
M src/com/google/caja/demos/playground/taming.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
felix8a
15 years, 4 months ago (2011-03-22 22:52:17 UTC) #1
Jasvir
15 years, 4 months ago (2011-03-23 21:36:59 UTC) #2
LGTM

http://codereview.appspot.com/4298056/diff/1/src/com/google/caja/demos/playgr...
File src/com/google/caja/demos/playground/examples/unboxed/index.html (right):

http://codereview.appspot.com/4298056/diff/1/src/com/google/caja/demos/playgr...
src/com/google/caja/demos/playground/examples/unboxed/index.html:86: debugger;
nuke the debugger line too.

http://codereview.appspot.com/4298056/diff/1/src/com/google/caja/demos/playgr...
src/com/google/caja/demos/playground/examples/unboxed/index.html:197: debugger;
ditto
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b