Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14832)

Issue 4298051: gdata-python resumable upload min chunk size

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by j.s
Modified:
13 years, 1 month ago
Reviewers:
jcgregorio
CC:
gdata-python-client-library-contributors_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding comment to explain the min chunk size for resumable upload. #

Patch Set 3 : Clarification on min chunk size resumable upload comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/gdata/client.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
j.s
13 years, 1 month ago (2011-03-18 23:28:54 UTC) #1
jcgregorio
http://codereview.appspot.com/4298051/diff/1/src/gdata/client.py File src/gdata/client.py (right): http://codereview.appspot.com/4298051/diff/1/src/gdata/client.py#newcode868 src/gdata/client.py:868: MIN_CHUNK_SIZE = 262144 # 256KB Is there a penalty ...
13 years, 1 month ago (2011-03-23 11:53:38 UTC) #2
j.s
13 years, 1 month ago (2011-03-23 17:26:10 UTC) #3
j.s
13 years, 1 month ago (2011-03-23 17:28:05 UTC) #4
j.s
http://codereview.appspot.com/4298051/diff/1/src/gdata/client.py File src/gdata/client.py (right): http://codereview.appspot.com/4298051/diff/1/src/gdata/client.py#newcode868 src/gdata/client.py:868: MIN_CHUNK_SIZE = 262144 # 256KB On 2011/03/23 11:53:38, jcgregorio ...
13 years, 1 month ago (2011-03-23 17:30:37 UTC) #5
jcgregorio
13 years, 1 month ago (2011-03-23 21:00:37 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b