Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(308)

Issue 4295064: remove valija/cajita from playground (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by felix8a
Modified:
15 years, 4 months ago
Reviewers:
Jasvir, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

this removes all refs to valija/cajita from the playground.

Patch Set 1 #

Patch Set 2 : remove valija/cajita from playground #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -53 lines) Patch
M src/com/google/caja/demos/playground/Playground.html View 1 1 chunk +0 lines, -12 lines 0 comments Download
M src/com/google/caja/demos/playground/client/policy.js View 1 4 chunks +8 lines, -14 lines 0 comments Download
M src/com/google/caja/demos/playground/client/ui/PlaygroundView.java View 1 1 chunk +1 line, -1 line 0 comments Download
D src/com/google/caja/demos/playground/setup-valija.js View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/com/google/caja/demos/playground/taming.js View 1 3 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 5
felix8a
15 years, 4 months ago (2011-03-23 07:07:52 UTC) #1
Jasvir
LGTM
15 years, 4 months ago (2011-03-23 21:34:05 UTC) #2
felix8a
this change breaks the playground flash example, because policy.js tries to modify parent.___ and throws ...
15 years, 4 months ago (2011-03-23 23:05:21 UTC) #3
felix8a
new snapshot fixes flash handling in policy.js, flash example works again.
15 years, 4 months ago (2011-03-25 19:49:11 UTC) #4
felix8a
15 years, 4 months ago (2011-04-08 08:07:11 UTC) #5
jasvir is working on integrating caja.js into the playground, which obsoletes
this change.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b