Issue 42910045: code review 42910045: image: roll back 13239051 (add RGB and RGB48)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 42910045: code review 42910045: image: roll back 13239051 (add RGB and RGB48) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by r

Modified:
11 years, 7 months ago

Reviewers:
nigeltao

CC:
golang-dev, nigeltao

Visibility:
Public.

Description

image: roll back 13239051 (add RGB and RGB48) They cause too much bloat in the internals as we find ourselves adding special case code for all the cross-connections. It's better to use RGBA and just max out the alpha. We lose a little memory but reduce the number of special cases the encoders, decoders, and drawers need to provide.

Patch Set 1 #

Patch Set 2 : diff -r 8cb5c6892fbc https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -218 lines)			Patch
M	src/pkg/image/color/color.go	View	3 chunks	+0 lines, -45 lines	0 comments	Download
M	src/pkg/image/image.go	View	1 chunk	+0 lines, -170 lines	0 comments	Download
M	src/pkg/image/image_test.go	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-12-16 23:23:44 UTC) #1

11 years, 7 months ago (2013-12-17 18:50:07 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d99f48a196e6 ***

image: roll back 13239051 (add RGB and RGB48)

They cause too much bloat in the internals as we find ourselves adding
special case code for all the cross-connections. It's better to use RGBA
and just max out the alpha. We lose a little memory but reduce the number
of special cases the encoders, decoders, and drawers need to provide.

R=golang-dev, nigeltao
CC=golang-dev
https://codereview.appspot.com/42910045

Expand All Messages | Collapse All Messages