code review 42890043: cmd/dist: avoid use of 'go tool pack'

cmd/dist: avoid use of 'go tool pack'

All packages now use the -pack option to the compiler.
For a pure Go package, that's enough.
For a package with additional C and assembly files, the extra
archive entries can be added directly (by concatenation)
instead of by invoking go tool pack.

These changes make it possible to rewrite cmd/pack in Go.

[rsc, 2013-12-16 18:08:14]

Hello iant, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-12-17 00:33:58]

LGTM

https://codereview.appspot.com/42890043/diff/40001/src/cmd/dist/build.c
File src/cmd/dist/build.c (right):

https://codereview.appspot.com/42890043/diff/40001/src/cmd/dist/build.c#newco...
src/cmd/dist/build.c:716: vadd(&link, "pack");
Why bother to add "pack" here?  As far as I can tell nothing ever refers to it. 
If you want it for easier debugging, perhaps a comment?

https://codereview.appspot.com/42890043/diff/40001/src/cmd/dist/build.c#newco...
src/cmd/dist/build.c:1250: // appending the files listed in extra.
Can you something about the archive format here?

https://codereview.appspot.com/42890043/diff/40001/src/cmd/dist/build.c#newco...
src/cmd/dist/build.c:1261: readfile(&b, src);
Why not just
    readfile(&bdst, src);

[rsc, 2013-12-18 02:34:54]

https://codereview.appspot.com/42890043/diff/40001/src/cmd/dist/build.c
File src/cmd/dist/build.c (right):

https://codereview.appspot.com/42890043/diff/40001/src/cmd/dist/build.c#newco...
src/cmd/dist/build.c:716: vadd(&link, "pack");
On 2013/12/17 00:33:58, iant wrote:
> Why bother to add "pack" here?  As far as I can tell nothing ever refers to
it. 
> If you want it for easier debugging, perhaps a comment?

Done.

https://codereview.appspot.com/42890043/diff/40001/src/cmd/dist/build.c#newco...
src/cmd/dist/build.c:1250: // appending the files listed in extra.
On 2013/12/17 00:33:58, iant wrote:
> Can you something about the archive format here?

Done.

https://codereview.appspot.com/42890043/diff/40001/src/cmd/dist/build.c#newco...
src/cmd/dist/build.c:1261: readfile(&b, src);
On 2013/12/17 00:33:58, iant wrote:
> Why not just
>     readfile(&bdst, src);

Done.

[rsc, 2013-12-18 02:44:23]

*** Submitted as https://code.google.com/p/go/source/detail?r=e8c8b0e2a52f ***

cmd/dist: avoid use of 'go tool pack'

All packages now use the -pack option to the compiler.
For a pure Go package, that's enough.
For a package with additional C and assembly files, the extra
archive entries can be added directly (by concatenation)
instead of by invoking go tool pack.

These changes make it possible to rewrite cmd/pack in Go.

R=iant, r
CC=golang-dev
https://codereview.appspot.com/42890043