Issue 4284066: Fix for RequestError caused by too many redirects

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by brianlum

Modified:
13 years ago

Reviewers:
jcgregorio, alainv

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	src/gdata/client.py	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brianlum

On 2011/03/24 20:27:00, brianlum wrote: I'm sorry, the issue should have been to fix issue ...

13 years, 1 month ago (2011-03-24 20:30:37 UTC) #2

alainv

13 years ago (2011-04-25 16:03:54 UTC) #3

On 2011/03/24 20:30:37, brianlum wrote:
> On 2011/03/24 20:27:00, brianlum wrote:
> 
> I'm sorry, the issue should have been to fix issue 268
> http://code.google.com/p/gdata-python-client/issues/detail?id=268
> 
> The following code shoudl reproduce the issue (about 20% of the time)
> import gdata.calendar.client
> client = gdata.calendar.client.CalendarClient(source='clienttest')
> client.ClientLogin('someone@somewhere.com', 'password', client.source)
> feed = client.GetCalendarEventFeed()
> 
> 
> I should get the feed, but I get the following exception:
> >>> feed = client.GetCalendarEventFeed()
> Traceback (most recent call last):
>   File "<stdin>", line 1, in ?
>   File "C:\Python24\Lib\site-packages\gdata\calendar\client.py", line 232, in
ge
> t_calendar_event_feed
>     desired_class=desired_class, **kwargs)
>   File "C:\Python24\lib\site-packages\gdata\client.py", line 634, in get_feed
>     converter=converter, desired_class=desired_class,
>   File "C:\Python24\lib\site-packages\gdata\client.py", line 298, in request
>     redirects_remaining=redirects_remaining-1,
>   File "C:\Python24\lib\site-packages\gdata\client.py", line 298, in request
>     redirects_remaining=redirects_remaining-1,
>   File "C:\Python24\lib\site-packages\gdata\client.py", line 298, in request
>     redirects_remaining=redirects_remaining-1,
>   File "C:\Python24\lib\site-packages\gdata\client.py", line 298, in request
>     redirects_remaining=redirects_remaining-1,
>   File "C:\Python24\lib\site-packages\gdata\client.py", line 305, in request
>     response, RedirectError)
> gdata.client.RedirectError: Too many redirects from server: 302, <HTML>
> <HEAD>
> <TITLE>Moved Temporarily</TITLE>
> </HEAD>
> <BODY BGCOLOR="#FFFFFF" TEXT="#000000">
> <H1>Moved Temporarily</H1>
> The document has moved <A
HREF="https://www.google.com/calendar/feeds/default/pr
> ivate/full?gsessionid=oWdatTrNHC5cB5z4t34tMg">here</A>.
> </BODY>
> </HTML>

LGTM!
Not sure if you need one of the owners to review this patch.

Best,
Alain

Expand All Messages | Collapse All Messages