Improve stock quantity computation with internal_quantity and periods

[erick, 2011-03-22 14:03:06]

After loading Patch 2, Confirm Order gives an error:

[Tue Mar 22 14:58:18 2011] ERROR:dispatcher:Exception calling method
workflow_trigger_validate on model sale.sale from 1@::1:53464/testek:
Traceback (most recent call last):
  File
"/home/eric/workspace/tryton_trunk/trytond/trytond/protocols/dispatcher.py",
line 139, in dispatch
    res = getattr(obj, method)(*args, **kargs)
  File
"/home/eric/workspace/tryton_trunk/trytond/trytond/model/modelworkflow.py", line
112, in workflow_trigger_validate
    instance_obj.validate(instance, signal=signal)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 211, in validate
    force_running=force_running)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 323, in process
    res = self._split_test(workitem, activity.split_mode, signal)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 441, in _split_test
    self._join_test(transition, instance)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 452, in _join_test
    'state': 'active',
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 301, in create
    self.process(workitem)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 323, in process
    res = self._split_test(workitem, activity.split_mode, signal)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 441, in _split_test
    self._join_test(transition, instance)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 452, in _join_test
    'state': 'active',
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 301, in create
    self.process(workitem)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 323, in process
    res = self._split_test(workitem, activity.split_mode, signal)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 441, in _split_test
    self._join_test(transition, instance)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 452, in _join_test
    'state': 'active',
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 301, in create
    self.process(workitem)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 317, in process
    if not self._execute(workitem, activity):
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/workflow.py",
line 364, in _execute
    workitem.instance.res_id, activity)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/expr.py",
line 61, in execute
    return eval_expr(model, obj_id, activity.action)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/expr.py",
line 50, in eval_expr
    res = safe_eval(line, env)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/tools/misc.py", line
442, in safe_eval
    }}, data)
  File "", line 1, in <module>
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/workflow/expr.py",
line 16, in __call__
    return getattr(self.obj, self.method)(self.obj_id, *args, **kargs)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/modules/sale/sale.py",
line 784, in create_shipment
    move_id = move_obj.create(vals)
  File
"/home/eric/workspace/tryton_trunk/trytond/trytond/modules/stock/move.py", line
510, in create
    return super(Move, self).create(vals)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/model/modelsql.py",
line 404, in create
    self._validate([id_new])
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/model/modelsql.py",
line 2153, in _validate
    super(ModelSQL, self)._validate(ids)
  File
"/home/eric/workspace/tryton_trunk/trytond/trytond/model/modelstorage.py", line
955, in _validate
    return self._validate(ids)
  File "/home/eric/workspace/tryton_trunk/trytond/trytond/model/modelsql.py",
line 2153, in _validate
    super(ModelSQL, self)._validate(ids)
  File
"/home/eric/workspace/tryton_trunk/trytond/trytond/model/modelstorage.py", line
958, in _validate
    if not getattr(self, field[0])(ids):
  File
"/home/eric/workspace/tryton_trunk/trytond/trytond/modules/stock/move.py", line
362, in check_period_closed
    if move.effective_date < period.date:
TypeError: can't compare datetime.date to NoneType

[erick, 2011-03-22 15:51:27]

Stock calculation and Period_cache works fine. It is possible to close the same
period more than once, is this necessary or should we prevent that?

Is it possible to use a cron-job for finalizing the stock? Now it is a manual
job and in case of more than 100.000 products this process might take a while.

[ced, 2011-03-22 16:00:43]

On 2011/03/22 15:51:27, eric.klaasse wrote:
> Stock calculation and Period_cache works fine. It is possible to close the
same
> period more than once, is this necessary or should we prevent that?

Fixed.

> Is it possible to use a cron-job for finalizing the stock? Now it is a manual
> job and in case of more than 100.000 products this process might take a while.

Why not there is just one method to call on period.

[nicoe, 2011-04-08 14:18:43]

http://codereview.appspot.com/4276068/diff/15001/move.py
File move.py (right):

http://codereview.appspot.com/4276068/diff/15001/move.py#newcode152
move.py:152: while True:
Again a while True that would be more clear by putting the condition in the
while.

http://codereview.appspot.com/4276068/diff/15001/move.py#newcode590
move.py:590: for move in self.browse(ids):
The ids used here might be stripped of those move where uom ==
product.default_uom to minimize calls to _get_internal_quantity

http://codereview.appspot.com/4276068/diff/15001/period.py
File period.py (right):

http://codereview.appspot.com/4276068/diff/15001/period.py#newcode36
period.py:36: 'close_period_future_today': ('You can not close a period in the
future '
80 cols

http://codereview.appspot.com/4276068/diff/15001/period.py#newcode68
period.py:68: recent_date = reduce(max, (period.date for period in periods))
max(period.date for period in periods) is enough

http://codereview.appspot.com/4276068/diff/15001/product.py
File product.py (right):

http://codereview.appspot.com/4276068/diff/15001/product.py#newcode200
product.py:200: move_rule_query, move_rule_val =
rule_obj.domain_get('stock.move')
renaming variable should be part of another patch

http://codereview.appspot.com/4276068/diff/15001/product.py#newcode424
product.py:424: # we already know that there will be no duplicates.
Should update the comment to talk about Period Cache

[ced, 2011-04-08 14:36:58]

http://codereview.appspot.com/4276068/diff/15001/move.py
File move.py (right):

http://codereview.appspot.com/4276068/diff/15001/move.py#newcode152
move.py:152: while True:
On 2011/04/08 14:18:43, nicoe wrote:
> Again a while True that would be more clear by putting the condition in the
> while.

Done.

http://codereview.appspot.com/4276068/diff/15001/move.py#newcode590
move.py:590: for move in self.browse(ids):
On 2011/04/08 14:18:43, nicoe wrote:
> The ids used here might be stripped of those move where uom ==
> product.default_uom to minimize calls to _get_internal_quantity

No, it also ensures that we have the right rounding.

http://codereview.appspot.com/4276068/diff/15001/period.py
File period.py (right):

http://codereview.appspot.com/4276068/diff/15001/period.py#newcode36
period.py:36: 'close_period_future_today': ('You can not close a period in the
future '
On 2011/04/08 14:18:43, nicoe wrote:
> 80 cols

Done.

http://codereview.appspot.com/4276068/diff/15001/period.py#newcode68
period.py:68: recent_date = reduce(max, (period.date for period in periods))
On 2011/04/08 14:18:43, nicoe wrote:
> max(period.date for period in periods) is enough

Done.

http://codereview.appspot.com/4276068/diff/15001/product.py
File product.py (right):

http://codereview.appspot.com/4276068/diff/15001/product.py#newcode200
product.py:200: move_rule_query, move_rule_val =
rule_obj.domain_get('stock.move')
On 2011/04/08 14:18:43, nicoe wrote:
> renaming variable should be part of another patch

It makes the code more readable since the query because bigger.

http://codereview.appspot.com/4276068/diff/15001/product.py#newcode424
product.py:424: # we already know that there will be no duplicates.
On 2011/04/08 14:18:43, nicoe wrote:
> Should update the comment to talk about Period Cache

Done.

[nicoe, 2011-04-08 19:27:30]

LGTM