code review 4274072: misc/notepadplus: add syntax and completion support for...

misc/notepadplus: add syntax and completion support for notepad++

[ajstarks, 2011-03-23 02:52:49]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-03-23 05:28:16]

Looks reasonable to me, but I don't like the + characters in the directory name.
Perhaps "notepadplusplus" instead?

[ajstarks, 2011-03-23 11:59:26]

ok, change to notepadplus -- this is the directory used by the official repo:
http://svn.tuxfamily.org/notepadplus/repository/

On Mar 23, 2011, at 1:28 AM, adg@golang.org wrote:

> Looks reasonable to me, but I don't like the + characters in the
> directory name. Perhaps "notepadplusplus" instead?
> 
> 
> http://codereview.appspot.com/4274072/

[adg, 2011-03-23 23:09:11]

Did you hg upload? Still looks like notepad++ to me.

On 23 March 2011 22:59, Anthony Starks <ajstarks@gmail.com> wrote:
> ok, change to notepadplus -- this is the directory used by the official
> repo: http://svn.tuxfamily.org/notepadplus/repository/
> On Mar 23, 2011, at 1:28 AM, adg@golang.org wrote:
>
> Looks reasonable to me, but I don't like the + characters in the
> directory name. Perhaps "notepadplusplus" instead?
>
>
> http://codereview.appspot.com/4274072/
>
>

[ajstarks, 2011-03-24 11:47:12]

Hello golang-dev@googlegroups.com, adg (cc: golang-dev@googlegroups.com),

Please take another look.

[peterGo, 2011-03-24 19:55:04]

http://codereview.appspot.com/4274072/diff/7002/misc/notepadplus/go.xml
File misc/notepadplus/go.xml (right):

http://codereview.appspot.com/4274072/diff/7002/misc/notepadplus/go.xml#newco...
misc/notepadplus/go.xml:10: <KeyWord name="complex" />
exchange complex and close to put them in alphabetical order

http://codereview.appspot.com/4274072/diff/7002/misc/notepadplus/userDefineLa...
File misc/notepadplus/userDefineLang.xml (right):

http://codereview.appspot.com/4274072/diff/7002/misc/notepadplus/userDefineLa...
misc/notepadplus/userDefineLang.xml:12: <Keywords name="Operators">( ) [ ] { }
... . , _ &amp; ^ %  &gt; &lt; ! =</Keywords>
this list of operators looks meager
http://golang.org/doc/go_spec.html#Operators_and_Delimiters

[ajstarks, 2011-03-24 23:16:01]

Hello golang-dev@googlegroups.com, adg, peterGo (cc:
golang-dev@googlegroups.com),

Please take another look.

[peterGo, 2011-03-25 00:58:30]

http://codereview.appspot.com/4274072/diff/12002/misc/notepadplus/go.xml
File misc/notepadplus/go.xml (right):

http://codereview.appspot.com/4274072/diff/12002/misc/notepadplus/go.xml#newc...
misc/notepadplus/go.xml:3: <Keyword name="append"/>
s/Keyword/KeyWord/g

[ajstarks, 2011-03-25 01:07:58]

Hello golang-dev@googlegroups.com, adg, peterGo (cc:
golang-dev@googlegroups.com),

Please take another look.

[ajstarks, 2011-03-31 11:51:22]

Hello golang-dev@googlegroups.com, adg, peterGo (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-04-01 03:44:16]

LGTM

[adg, 2011-04-01 03:45:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=6ae937673256 ***

misc/notepadplus: add syntax and completion support for notepad++

R=golang-dev, adg, peterGo
CC=golang-dev
http://codereview.appspot.com/4274072

Committer: Andrew Gerrand <adg@golang.org>