Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(395)

Issue 4274066: Implement Array.forEach on browsers that do not provide it for ES53's internal use. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by Jasvir
Modified:
15 years ago
Reviewers:
Jasvir, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

ES53 uses forEach internally distinct from the version it exposes to cajoled code. This CL provides a version .forEach for browsers that do not provide it. See http://code.google.com/p/google-caja/issues/detail?id=1328 @4402

Patch Set 1 #

Total comments: 1

Patch Set 2 : Implement Array.forEach on browsers that do not provide it for ES53's internal use. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/com/google/caja/es53.js View 1 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 5
Jasvir
15 years ago (2011-03-17 06:40:22 UTC) #1
Jasvir
ping
15 years ago (2011-03-21 15:45:54 UTC) #2
metaweta
http://codereview.appspot.com/4274066/diff/1/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right): http://codereview.appspot.com/4274066/diff/1/src/com/google/caja/es53.js#newcode185 src/com/google/caja/es53.js:185: // Missing on IE Since we're now creating this ...
15 years ago (2011-03-21 20:56:59 UTC) #3
Jasvir
snapshot
15 years ago (2011-03-22 20:58:24 UTC) #4
metaweta
15 years ago (2011-03-22 22:00:37 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b