Issue 4267045: Oprava session module aby fungovala na localhoste

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4267045: Oprava session module aby fungovala na localhoste (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by descent89

Modified:
13 years, 1 month ago

Reviewers:
ppershing, anty

CC:
fajr-devel+codereview_googlegroups.com

Base URL:
http://fajr.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Oprava session module aby fungovala na localhoste Fixes issue 97

Patch Set 1 #

Total comments: 2

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/modules/SessionModule.php	View		1 chunk	+5 lines, -1 line	2 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

ppershing

lgtm http://codereview.appspot.com/4267045/diff/1/src/modules/SessionModule.php File src/modules/SessionModule.php (right): http://codereview.appspot.com/4267045/diff/1/src/modules/SessionModule.php#newcode55 src/modules/SessionModule.php:55: if ($_SERVER['HTTP_HOST'] == 'localhost') { add a comment, ...

13 years, 1 month ago (2011-03-08 18:10:01 UTC) #1

descent89

On 2011/03/21 21:59:26, anty wrote: > ping lgtm... kto to komitne?

13 years, 1 month ago (2011-03-22 00:05:48 UTC) #3

descent89

http://codereview.appspot.com/4267045/diff/1/src/modules/SessionModule.php File src/modules/SessionModule.php (right): http://codereview.appspot.com/4267045/diff/1/src/modules/SessionModule.php#newcode55 src/modules/SessionModule.php:55: if ($_SERVER['HTTP_HOST'] == 'localhost') { On 2011/03/08 18:10:01, ppershing ...

13 years, 1 month ago (2011-03-22 00:17:52 UTC) #4

anty

On 2011/03/22 00:05:48, descent89 wrote: > On 2011/03/21 21:59:26, anty wrote: > > ping > ...

13 years, 1 month ago (2011-03-22 08:11:27 UTC) #5

anty

13 years, 1 month ago (2011-03-22 08:11:47 UTC) #6

On 2011/03/22 00:17:52, descent89 wrote:
> http://codereview.appspot.com/4267045/diff/1/src/modules/SessionModule.php
> File src/modules/SessionModule.php (right):
> 
>
http://codereview.appspot.com/4267045/diff/1/src/modules/SessionModule.php#ne...
> src/modules/SessionModule.php:55: if ($_SERVER['HTTP_HOST'] == 'localhost')  {
> On 2011/03/08 18:10:01, ppershing wrote:
> > add a comment, why this is needed.
> 
> beacause session_cookie_domain set on localhost renders FAJR unusable. this
> simply enhances out-of-the-box experience for FAJR devs/users running FAJR on
> localhost
Treba napisat do kodu ako komentar

Expand All Messages | Collapse All Messages