Issue 42590043: code review 42590043: doc/install-source.html: mention make.bash to skip tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 42590043: code review 42590043: doc/install-source.html: mention make.bash to skip tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by minux1

Modified:
12 years ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

doc/install-source.html: mention make.bash to skip tests

Patch Set 2 : diff -r 3cb71b69695a https://code.google.com/p/go #

Patch Set 3 : diff -r 3cb71b69695a https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 3cb71b69695a https://code.google.com/p/go #

Patch Set 5 : diff -r 82133bc0be40 https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	doc/install-source.html	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-12-16 01:02:54 UTC) #1

adg

LGTM https://codereview.appspot.com/42590043/diff/40001/doc/install-source.html File doc/install-source.html (right): https://codereview.appspot.com/42590043/diff/40001/doc/install-source.html#newcode181 doc/install-source.html:181: the test suite, please run <code>make.bash</code> (or <code>make.bat</code>) ...

12 years ago (2013-12-16 01:04:17 UTC) #2

minux1

12 years ago (2013-12-16 02:03:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=cfd85d12efea ***

doc/install-source.html: mention make.bash to skip tests

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/42590043

Expand All Messages | Collapse All Messages