Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 42570043: code review 42570043: unicode/utf16: add explicit tests for IsSurrogate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by dfc
Modified:
8 years, 11 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

unicode/utf16: add explicit tests for IsSurrogate Update issue 6956 Add tests for IsSurrogate.

Patch Set 1 #

Patch Set 2 : diff -r 1053bd434eaa https://code.google.com/p/go #

Patch Set 3 : diff -r 1053bd434eaa https://code.google.com/p/go #

Patch Set 4 : diff -r 3cb71b69695a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M src/pkg/unicode/utf16/utf16_test.go View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
8 years, 11 months ago (2013-12-15 23:32:23 UTC) #1
r
LGTM
8 years, 11 months ago (2013-12-16 00:04:22 UTC) #2
dfc
Thanks r. Submitting. On Mon, Dec 16, 2013 at 11:04 AM, <r@golang.org> wrote: > LGTM ...
8 years, 11 months ago (2013-12-16 00:05:16 UTC) #3
dfc
8 years, 11 months ago (2013-12-16 00:15:45 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=bccf584859d6 ***

unicode/utf16: add explicit tests for IsSurrogate

Update issue 6956

Add tests for IsSurrogate.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/42570043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b