Fix issue (498) and clean up ContactsClient class definition and sample code.

+vicfryzel

[Vince, 2011-03-01 19:21:25]

I don't see any problems and the profilequery needed to be done. I tested and
works as expected.

[alainv, 2011-03-01 19:26:09]

On 2011/03/01 19:21:25, Vince wrote:
> I don't see any problems and the profilequery needed to be done. I tested and
> works as expected.

Well, the ProfilesQuery should add support for the max-results and start-key
query parameter.
Also, since it is used in the gdata.client.get_feed method, and it extends
gdata.client.Query, it needs to "override" modify_request to add the other
supported parameters.

Also, coud you post the code you used for your test?

Thanks,
Alain

[alainv, 2011-03-15 21:38:36]

Ping!

[alainv, 2011-03-21 22:41:02]

Vic, Joe,

Can I get a review on this please?
Thanks!

Alain

[jcgregorio, 2011-03-23 11:47:22]

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py#new...
src/gdata/contacts/client.py:521: if self.start_key:
Can you add some tests for this?

[alainv, 2011-03-23 15:58:07]

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py#new...
src/gdata/contacts/client.py:521: if self.start_key:
On 2011/03/23 11:47:22, jcgregorio wrote:
> Can you add some tests for this?

What kind of tests are you looking for? Do you want me to check that the
http_request is correctly modified or that a request to the server is working?
For the latter, do we have a Google Apps for business account for testing since
the Profiles API is only available for those types of domain.

Thanks,
Alain

[jcgregorio, 2011-03-23 17:22:10]

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py#new...
src/gdata/contacts/client.py:521: if self.start_key:
At the very least a test that http_request is correctly modified. Preferably
also a live test. If I don't have a Google Apps for Business account I will get
one for running such tests.

On 2011/03/23 15:58:07, alainv wrote:
> On 2011/03/23 11:47:22, jcgregorio wrote:
> > Can you add some tests for this?
> 
> What kind of tests are you looking for? Do you want me to check that the
> http_request is correctly modified or that a request to the server is working?
> For the latter, do we have a Google Apps for business account for testing
since
> the Profiles API is only available for those types of domain.
> 
> Thanks,
> Alain

[alainv, 2011-03-24 16:17:39]

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py#new...
src/gdata/contacts/client.py:521: if self.start_key:
I will add the test that verifies the modification of the http_request. For the
live request, the start-key is returned by the API, this is not something that I
can generate.
I was also wondering if we could add a generic custom parameters list to the
gdata.client.Query class.

Thanks,
Alain

On 2011/03/23 17:22:10, jcgregorio wrote:
> At the very least a test that http_request is correctly modified. Preferably
> also a live test. If I don't have a Google Apps for Business account I will
get
> one for running such tests.
> 
> On 2011/03/23 15:58:07, alainv wrote:
> > On 2011/03/23 11:47:22, jcgregorio wrote:
> > > Can you add some tests for this?
> > 
> > What kind of tests are you looking for? Do you want me to check that the
> > http_request is correctly modified or that a request to the server is
working?
> > For the latter, do we have a Google Apps for business account for testing
> since
> > the Profiles API is only available for those types of domain.
> > 
> > Thanks,
> > Alain
>

[jcgregorio, 2011-03-24 17:29:38]

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4254047/diff/1/src/gdata/contacts/client.py#new...
src/gdata/contacts/client.py:521: if self.start_key:
Do you mean add a *kwargs to
http://code.google.com/p/gdata-python-client/source/browse/src/gdata/client.p...
and take all of them as query parameters for the query? Sounds reasonable to me,
but let's do that as a separate CL.

On 2011/03/24 16:17:39, alainv wrote:
> I will add the test that verifies the modification of the http_request. For
the
> live request, the start-key is returned by the API, this is not something that
I
> can generate.
> I was also wondering if we could add a generic custom parameters list to the
> gdata.client.Query class.
> 
> Thanks,
> Alain
> 
> On 2011/03/23 17:22:10, jcgregorio wrote:
> > At the very least a test that http_request is correctly modified. Preferably
> > also a live test. If I don't have a Google Apps for Business account I will
> get
> > one for running such tests.
> > 
> > On 2011/03/23 15:58:07, alainv wrote:
> > > On 2011/03/23 11:47:22, jcgregorio wrote:
> > > > Can you add some tests for this?
> > > 
> > > What kind of tests are you looking for? Do you want me to check that the
> > > http_request is correctly modified or that a request to the server is
> working?
> > > For the latter, do we have a Google Apps for business account for testing
> > since
> > > the Profiles API is only available for those types of domain.
> > > 
> > > Thanks,
> > > Alain
> > 
>

[alainv, 2011-03-30 16:57:01]

On 2011/03/29 22:27:42, alainv wrote:

Added the live test.

[jcgregorio, 2011-03-30 17:20:45]

LGTM