Issue 4252055: Review: auto generate oslversion.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4252055: Review: auto generate oslversion.h

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by larrygritz

Modified:
13 years, 1 month ago

Reviewers:
dev-osl, osl-dev, ckulla

Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Mimicking the way Jeremy set it up for OIIO, this patches makes it so that version numbers are set in just one place -- src/CMakeList.txt, and oslversion.h is generated automatically from these versions and the template in oslversion.h.in.

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+104 lines, -49 lines)			Patch
src/CMakeLists.txt	View	4 chunks	+20 lines, -9 lines	0 comments	Download
src/include/CMakeLists.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
src/include/oslconfig.h	View	2 chunks	+5 lines, -39 lines	0 comments	Download
src/include/oslversion.h.in	View	1 chunk	+72 lines, -0 lines	0 comments	Download
src/liboslexec/CMakeLists.txt	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages