Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(313)

Issue 42390043: code review 42390043: strings: Update Trim example. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by u
Modified:
11 years, 6 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

strings: Update Trim example. Use an input which better shows that behaviour of the function. Only leading and trailing runes are trimed, not intermediate ones.

Patch Set 1 #

Patch Set 2 : diff -r 24bc2c8febe3 https://code.google.com/p/go #

Patch Set 3 : diff -r 24bc2c8febe3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/strings/example_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
u
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2013-12-14 20:51:04 UTC) #1
bradfitz
LGTM On Sat, Dec 14, 2013 at 12:51 PM, <r.eklind.87@gmail.com> wrote: > Reviewers: golang-dev1, > ...
11 years, 7 months ago (2013-12-16 18:40:12 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=9ba849c79980 *** strings: Update Trim example. Use an input which better shows ...
11 years, 7 months ago (2013-12-16 18:40:30 UTC) #3
u
11 years, 6 months ago (2014-01-11 10:09:36 UTC) #4
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b