code review 42310045: bytes, strings: improve Title test coverage by adding c...

bytes, strings: improve Title test coverage by adding cases with underscore and unicode line separator

[shawnps, 2013-12-15 12:22:58]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[gobot, 2013-12-18 16:03:53]

R=r@golang.org (assigned by rsc@golang.org)

[r, 2013-12-19 19:42:04]

LGTM

[r, 2013-12-19 19:42:52]

On 2013/12/19 19:42:04, r wrote:
> LGTM

On second thought, shouldn't the same tests appear in the strings package?

[shawnps, 2013-12-20 14:25:21]

On 2013/12/19 19:42:52, r wrote:
> On 2013/12/19 19:42:04, r wrote:
> > LGTM
> 
> On second thought, shouldn't the same tests appear in the strings package?

You're right, I'll add these for the strings package as well.

[gobot, 2013-12-20 16:26:20]

Replacing golang-dev with golang-codereviews.

[shawnps, 2013-12-21 05:36:31]

On 2013/12/19 19:42:52, r wrote:
> On 2013/12/19 19:42:04, r wrote:
> > LGTM
> 
> On second thought, shouldn't the same tests appear in the strings package?

strings package CL is here: https://codereview.appspot.com/42280047

or should I have added the strings package tests to this CL?

[r, 2013-12-21 05:56:22]

Please put the two into one CL.

[shawnps, 2013-12-21 06:06:00]

Hello golang-codereviews@googlegroups.com, gobot@golang.org, r@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[shawnps, 2013-12-21 06:08:42]

On 2013/12/21 06:06:00, shawnps wrote:
> Hello mailto:golang-codereviews@googlegroups.com, mailto:gobot@golang.org,
mailto:r@golang.org (cc:
> mailto:golang-codereviews@googlegroups.com),
> 
> Please take another look.

It seems like the files are in separate patch sets now. I ran `hg file 42310045
src/pkg/strings/strings_test.go` since that is what is suggested on the
Contribution Guidelines for adding files to an existing change. Is this fine, or
did I miss a step somewhere?

[shawnps, 2013-12-21 06:11:09]

Hello golang-codereviews@googlegroups.com, gobot@golang.org, r@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[r, 2013-12-21 07:17:46]

LGTM

[r, 2013-12-21 07:19:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=c4b7c0824984 ***

bytes, strings: improve Title test coverage by adding cases with underscore and
unicode line separator

R=golang-codereviews, gobot, r
CC=golang-codereviews
https://codereview.appspot.com/42310045

Committer: Rob Pike <r@golang.org>

[dave_cheney.net, 2013-12-30 02:10:28]

Shawn, if this CL has been superseded please use

   hg change -d 42280047

To abandon it (don't use the delete function in rietveld, 'cos we
won't get a message about that)

On Sat, Dec 21, 2013 at 4:56 PM, Rob Pike <r@golang.org> wrote:
> Please put the two into one CL.
>
> --
> You received this message because you are subscribed to the Google Groups
"golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[shawnps, 2013-12-30 02:20:12]

On 2013/12/30 02:10:28, dfc wrote:
> Shawn, if this CL has been superseded please use
> 
>    hg change -d 42280047
> 
> To abandon it (don't use the delete function in rietveld, 'cos we
> won't get a message about that)
> 
> On Sat, Dec 21, 2013 at 4:56 PM, Rob Pike <mailto:r@golang.org> wrote:
> > Please put the two into one CL.
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email to mailto:golang-codereviews+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/groups/opt_out.

I'm happy to do that, but I'm not exactly sure what you mean because it seems
like it was submitted and not superseded by another CL. Also would I substitute
42280047 with 42310045?

[shawnps, 2013-12-30 02:21:40]

On 2013/12/30 02:20:12, shawnps wrote:
> On 2013/12/30 02:10:28, dfc wrote:
> > Shawn, if this CL has been superseded please use
> > 
> >    hg change -d 42280047
> > 
> > To abandon it (don't use the delete function in rietveld, 'cos we
> > won't get a message about that)
> > 
> > On Sat, Dec 21, 2013 at 4:56 PM, Rob Pike <mailto:r@golang.org> wrote:
> > > Please put the two into one CL.
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > "golang-codereviews" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an
> > email to mailto:golang-codereviews+unsubscribe@googlegroups.com.
> > > For more options, visit https://groups.google.com/groups/opt_out.
> 
> I'm happy to do that, but I'm not exactly sure what you mean because it seems
> like it was submitted and not superseded by another CL. Also would I
substitute
> 42280047 with 42310045?

Oh sorry, I get it. I deleted the other CL via rietveld. I'll use hg change -d
from now on. Sorry about that.