Issue 423041: code review 423041: Slice reversal with a twist

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 423041: code review 423041: Slice reversal with a twist

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by matti.paksula

Modified:
9 years, 7 months ago

Reviewers:
kaib

Visibility:
Public.

Description

Slice reversal with a twist

Patch Set 1 #

Patch Set 2 : code review 423041: Slice reversal with a twist #

Total comments: 2

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -0 lines)			Patch
	A	matti.paksula/slice_reversal.go	View		1 chunk	+64 lines, -0 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kaib

14 years, 1 month ago (2010-03-11 13:39:08 UTC) #2

lgtm

http://codereview.appspot.com/423041/diff/2001/3001
File matti.paksula/slice_reversal.go (right):

http://codereview.appspot.com/423041/diff/2001/3001#newcode14
matti.paksula/slice_reversal.go:14: tmp := s[right]
use multiple assignment to get rid of the temp
s[left], s[right] = s[right], s[left]

http://codereview.appspot.com/423041/diff/2001/3001#newcode24
matti.paksula/slice_reversal.go:24: type PimpedSlice []int
cheap thrills..

Expand All Messages | Collapse All Messages