code review 41960047: encoding/json: add tests for InvalidUnmarshalError

encoding/json: add tests for InvalidUnmarshalError

[dave_cheney.net, 2013-12-31 21:25:06]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[shawnps, 2014-01-01 10:35:13]

https://codereview.appspot.com/41960047/diff/40001/src/pkg/encoding/json/deco...
File src/pkg/encoding/json/decode_test.go (right):

https://codereview.appspot.com/41960047/diff/40001/src/pkg/encoding/json/deco...
src/pkg/encoding/json/decode_test.go:1332: got := Unmarshal(buf, tt.v)
Would it be nicer to name this err instead, or is it standard/fine to reuse
"got" like you do below?

[dave_cheney.net, 2014-01-01 11:31:45]

https://codereview.appspot.com/41960047/diff/40001/src/pkg/encoding/json/deco...
File src/pkg/encoding/json/decode_test.go (right):

https://codereview.appspot.com/41960047/diff/40001/src/pkg/encoding/json/deco...
src/pkg/encoding/json/decode_test.go:1332: got := Unmarshal(buf, tt.v)
On 2014/01/01 10:35:13, shawnps wrote:
> Would it be nicer to name this err instead, or is it standard/fine to reuse
> "got" like you do below?

Yeah, good point.

[dave_cheney.net, 2014-01-01 11:32:49]

Hello golang-codereviews@googlegroups.com, shawn.p.smith@gmail.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[shawnps, 2014-01-01 11:35:15]

On 2014/01/01 11:32:49, dfc wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
mailto:shawn.p.smith@gmail.com (cc:
> mailto:golang-codereviews@googlegroups.com),
> 
> Please take another look.

LGTM

before:
PASS
coverage: 89.2% of statements
ok  	encoding/json	0.290s
encoding/json/decode.go:	unmarshal			81.8%

after:
PASS
coverage: 89.6% of statements
ok  	encoding/json	0.284s
encoding/json/decode.go:	unmarshal			90.9%

[dave_cheney.net, 2014-01-01 22:50:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=5330d59be152 ***

encoding/json: add tests for InvalidUnmarshalError

R=golang-codereviews, shawn.p.smith
CC=golang-codereviews
https://codereview.appspot.com/41960047