code review 4172055: goinstall: handle $(GOOS) and $(GOARCH) in filenames

goinstall: handle $(GOOS) and $(GOARCH) in filenames

This enables goinstall to handle .go and .c files (for cgo)
which are named after the following patterns:

    name_$(GOOS).*
    name_$(GOARCH).*
    name_$(GOOS)_$(GOARCH).*

Files with those names are only included if the $(GOOS) and
$(GOARCH) match the current system.

[niemeyer, 2011-03-06 18:36:28]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-03-06 20:06:30]

R=rsc

[rsc, 2011-03-06 20:57:47]

looks good

http://codereview.appspot.com/4172055/diff/17001/src/Make.cmd
File src/Make.cmd (right):

http://codereview.appspot.com/4172055/diff/17001/src/Make.cmd#newcode32
src/Make.cmd:32: test.gotest:
I'd rather avoid more makefile hackery.
Can we drop this and put

test:
    gotest

in the goinstall Makefile for now?

Same for Make.pkg.

http://codereview.appspot.com/4172055/diff/17001/src/Make.inc
File src/Make.inc (right):

http://codereview.appspot.com/4172055/diff/17001/src/Make.inc#newcode32
src/Make.inc:32: GOOS_LIST:=\
use = unless you are overriding.

http://codereview.appspot.com/4172055/diff/17001/src/Make.inc#newcode37
src/Make.inc:37: tiny\
delete; i should have deleted it before

http://codereview.appspot.com/4172055/diff/17001/src/Make.inc#newcode40
src/Make.inc:40: GOARCH_LIST:=\
s/:=/=/

http://codereview.appspot.com/4172055/diff/17001/src/cmd/goinstall/parse.go
File src/cmd/goinstall/parse.go (right):

http://codereview.appspot.com/4172055/diff/17001/src/cmd/goinstall/parse.go#n...
src/cmd/goinstall/parse.go:153: goodOS[v] = (v == runtime.GOOS)
drop ( )

http://codereview.appspot.com/4172055/diff/17001/src/cmd/goinstall/parse.go#n...
src/cmd/goinstall/parse.go:156: goodArch[v] = (v == runtime.GOARCH)
drop ( )

[niemeyer, 2011-03-06 22:11:08]

> I'd rather avoid more makefile hackery.
> Can we drop this and put

Yes, that works. My goal was to make Make.pkg and Make.cmd even
in those terms, so that they both have the same testing targets.

Either way, I've reverted.  If you agree, I can submit a separate
CL later to do this.

Other items addressed too. PTAL

[niemeyer, 2011-03-07 00:06:14]

Uploaded again to address conflicts from filepath merge.

[rsc, 2011-03-07 14:43:28]

LGTM

[rsc, 2011-03-07 15:31:30]

Tried to apply + submit but it appears that
syslist_test.go has been dropped from the files list.

Russ

[niemeyer, 2011-03-07 15:46:35]

> Tried to apply + submit but it appears that
> syslist_test.go has been dropped from the files list.

And indeed it was.  Please try again.

[rsc, 2011-03-07 15:54:58]

*** Submitted as b51ad23ee7fb ***

goinstall: handle $(GOOS) and $(GOARCH) in filenames

This enables goinstall to handle .go and .c files (for cgo)
which are named after the following patterns:

    name_$(GOOS).*
    name_$(GOARCH).*
    name_$(GOOS)_$(GOARCH).*

Files with those names are only included if the $(GOOS) and
$(GOARCH) match the current system.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4172055

Committer: Russ Cox <rsc@golang.org>