src/cmd/goinstall/Makefile - Issue 4172055: code review 4172055: goinstall: handle $(GOOS) and $(GOARCH) in filenames

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/cmd/goinstall/Makefile

Issue 4172055: code review 4172055: goinstall: handle $(GOOS) and $(GOARCH) in filenames (Closed)

Left Patch Set: diff -r 03da6860bb39 https://go.googlecode.com/hg/ Created 14 years ago

Right Patch Set: diff -r 66ad99aa592e https://go.googlecode.com/hg/ Created 14 years ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # Copyright 2009 The Go Authors. All rights reserved.	1 # Copyright 2009 The Go Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style	2 # Use of this source code is governed by a BSD-style

3 # license that can be found in the LICENSE file.	3 # license that can be found in the LICENSE file.

4	4

5 include ../../Make.inc	5 include ../../Make.inc

6	6

7 TARG=goinstall	7 TARG=goinstall

8 GOFILES=\	8 GOFILES=\

9 download.go\	9 download.go\

10 main.go\	10 main.go\

11 make.go\	11 make.go\

12 parse.go\	12 parse.go\

13 syslist.go\	13 syslist.go\

14	14

15 CLEANFILES+=syslist.go	15 CLEANFILES+=syslist.go

16	16

17 include ../../Make.cmd	17 include ../../Make.cmd

18	18

19 syslist.go:	19 syslist.go:

20 echo '// Generated automatically by make.' >$@	20 echo '// Generated automatically by make.' >$@

21 echo 'package main' >>$@	21 echo 'package main' >>$@

22 echo 'const goosList = "$(GOOS_LIST)"' >>$@	22 echo 'const goosList = "$(GOOS_LIST)"' >>$@

23 echo 'const goarchList = "$(GOARCH_LIST)"' >>$@	23 echo 'const goarchList = "$(GOARCH_LIST)"' >>$@

	24

	25 test:

	26 gotest

LEFT	RIGHT