Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1446)

Issue 41530045: ASL BSD Plaintext for Mac OS X.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by Joaquin Moreno
Modified:
9 years, 5 months ago
Reviewers:
kiddi
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

These files are missing unit tests: + plaso/formatters/mac_bsdplaintext.py + plaso/parsers/__init__.py

Patch Set 1 #

Patch Set 2 : Uploading changes made to code. #

Patch Set 3 : Uploading changes made to code. #

Total comments: 5

Patch Set 4 : Uploading changes made to code. #

Patch Set 5 : Uploading changes made to code. #

Patch Set 6 : Uploading changes made to code. #

Patch Set 7 : Uploading changes made to code. #

Total comments: 18
Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -0 lines) Patch
A plaso/parsers/mac_syslog.py View 1 2 3 4 5 1 chunk +237 lines, -0 lines 10 comments Download
A plaso/parsers/mac_syslog_test.py View 1 2 3 4 5 1 chunk +168 lines, -0 lines 8 comments Download
A test_data/mac_bsd_syslog View 1 2 3 4 5 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 18
Joaquin Moreno
10 years, 4 months ago (2013-12-25 03:40:09 UTC) #1
Joaquin Moreno
Code updated.
10 years, 4 months ago (2013-12-25 03:45:33 UTC) #2
Joaquin Moreno
Well, this is a proof of concept because it is not able to read all ...
10 years, 4 months ago (2013-12-25 04:44:59 UTC) #3
Joaquin Moreno
Code updated.
10 years, 4 months ago (2013-12-26 00:32:20 UTC) #4
Joaquin Moreno
New version completely re-programmed. It is not so clear code, but it can parse all ...
10 years, 4 months ago (2013-12-26 00:37:00 UTC) #5
kiddi
Few comments this time, but I think you should not use the base parser but ...
10 years, 4 months ago (2013-12-30 19:29:37 UTC) #6
Joaquin Moreno
Code updated.
10 years, 3 months ago (2014-01-02 03:25:25 UTC) #7
Joaquin Moreno
Syslog using Pyparsing and multiline from text_parsed instead of regular expression. I have detected some ...
10 years, 3 months ago (2014-01-02 03:43:20 UTC) #8
kiddi
so are you removing the old syslog parser for this one?
10 years, 3 months ago (2014-01-02 18:50:42 UTC) #9
Joaquin Moreno
On 2014/01/02 18:50:42, kiddi wrote: > so are you removing the old syslog parser for ...
10 years, 3 months ago (2014-01-02 18:52:37 UTC) #10
kiddi
I'm reviewing the multi line parser right now and looking at this implementation as a ...
10 years, 3 months ago (2014-01-06 23:10:09 UTC) #11
Joaquin Moreno
Code updated.
10 years, 2 months ago (2014-02-01 15:08:54 UTC) #12
Joaquin Moreno
Code updated.
10 years, 2 months ago (2014-02-07 23:00:12 UTC) #13
Joaquin Moreno
First of all, sorry for the delay. Normal syslog works well using the pyparsing, can ...
10 years, 2 months ago (2014-02-07 23:05:03 UTC) #14
Joaquin Moreno
Code updated.
10 years, 2 months ago (2014-02-09 02:24:07 UTC) #15
Joaquin Moreno
Now only multiline support (ASL BSD plaintext).
10 years, 2 months ago (2014-02-09 02:26:17 UTC) #16
kiddi
Few comments, been a while since I looked at this CL, sorry for the extremely ...
10 years, 1 month ago (2014-03-26 21:54:43 UTC) #17
kiddi
9 years, 5 months ago (2014-11-23 00:37:25 UTC) #18
Any news/updates?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b