Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 41170043: code review 41170043: go.tools/go/exact: serialization support and better unk... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by gri
Modified:
7 years, 10 months ago
Reviewers:
adonovan
CC:
golang-dev
Visibility:
Public.

Description

go.tools/go/exact: serialization support and better unknown handling - fixed various imprecise doc strings - consistent handling of unknown values

Patch Set 1 #

Patch Set 2 : diff -r de58424a6f88 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 000d539042f7 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 000d539042f7 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r af8717213853 https://code.google.com/p/go.tools #

Patch Set 6 : diff -r af8717213853 https://code.google.com/p/go.tools #

Total comments: 14

Patch Set 7 : diff -r a5b52e9abb06 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -57 lines) Patch
M go/exact/exact.go View 1 2 3 4 5 6 19 chunks +185 lines, -52 lines 0 comments Download
M go/exact/exact_test.go View 1 2 3 4 6 chunks +113 lines, -5 lines 0 comments Download

Messages

Total messages: 6
gri
Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
7 years, 10 months ago (2013-12-12 21:13:11 UTC) #1
adonovan
LGTM https://codereview.appspot.com/41170043/diff/100001/go/exact/exact.go File go/exact/exact.go (right): https://codereview.appspot.com/41170043/diff/100001/go/exact/exact.go#newcode325 go/exact/exact.go:325: panic(fmt.Sprintf("invalid Bits(%v)", x)) "Bits"? How about: "Bytes(%v): not ...
7 years, 10 months ago (2013-12-12 21:29:12 UTC) #2
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=3fbe8ee3708b&repo=tools *** go.tools/go/exact: serialization support and better unknown handling - fixed various ...
7 years, 10 months ago (2013-12-12 21:42:57 UTC) #3
gri
7 years, 10 months ago (2013-12-12 21:43:08 UTC) #4
adonovan
https://codereview.appspot.com/41170043/diff/100001/go/exact/exact.go File go/exact/exact.go (right): https://codereview.appspot.com/41170043/diff/100001/go/exact/exact.go#newcode437 go/exact/exact.go:437: return int64Val(0) On 2013/12/12 21:29:12, adonovan wrote: > Isn't ...
7 years, 10 months ago (2013-12-12 21:58:31 UTC) #5
gri
7 years, 10 months ago (2013-12-12 22:17:45 UTC) #6
Message was sent while issue was closed.
https://codereview.appspot.com/41170043/diff/100001/go/exact/exact.go
File go/exact/exact.go (right):

https://codereview.appspot.com/41170043/diff/100001/go/exact/exact.go#newcode437
go/exact/exact.go:437: return int64Val(0)
On 2013/12/12 21:58:31, adonovan wrote:
> On 2013/12/12 21:29:12, adonovan wrote:
> > Isn't the real part of an integer... all of it?
> 
> Sorry, I should have been more explicit: this is a bug.
> The correct result is x.

https://codereview.appspot.com/37820052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b