Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2154)

Issue 41060044: code review 41060044: syscall: replace mksyscall_windows.pl with mksyscall_wi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by brainman
Modified:
10 years, 1 month ago
Reviewers:
rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

syscall: replace mksyscall_windows.pl with mksyscall_windows.go Not many windows users have perl installed. They can just use standard go tools instead. Also mkerrors_windows.sh script removed - we don't add any new "unix" errors to windows syscall package anymore.

Patch Set 1 #

Patch Set 2 : diff -r f57908289898 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f57908289898 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7bacfe93a7a3 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+703 lines, -556 lines) Patch
M src/pkg/syscall/mkall.sh View 1 2 3 3 chunks +18 lines, -19 lines 0 comments Download
A src/pkg/syscall/mkall_windows.bat View 1 1 chunk +21 lines, -0 lines 0 comments Download
R src/pkg/syscall/mkerrors_windows.sh View 1 1 chunk +0 lines, -202 lines 0 comments Download
A src/pkg/syscall/mksyscall_windows.go View 1 1 chunk +662 lines, -0 lines 0 comments Download
R src/pkg/syscall/mksyscall_windows.pl View 1 1 chunk +0 lines, -333 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 4 months ago (2013-12-20 11:10:21 UTC) #1
gobot
Replacing golang-dev with golang-codereviews.
10 years, 4 months ago (2013-12-20 16:26:15 UTC) #2
gobot
Replacing golang-dev with golang-codereviews.
10 years, 4 months ago (2013-12-20 16:26:16 UTC) #3
rsc
Thanks very much for doing this. We split mksyscall_windows.pl from mksyscall.pl because there was enough ...
10 years, 4 months ago (2013-12-20 16:55:47 UTC) #4
brainman
I should have discussed my plan before I started. But I didn't know there would ...
10 years, 4 months ago (2013-12-21 02:04:45 UTC) #5
brainman
Russ, do you still want to proceed with this? Alex
10 years, 1 month ago (2014-03-04 10:42:10 UTC) #6
rsc
LGTM This is fine for now.
10 years, 1 month ago (2014-03-05 20:25:04 UTC) #7
brainman
10 years, 1 month ago (2014-03-11 05:36:21 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=3cd546ac3a99 ***

syscall: replace mksyscall_windows.pl with mksyscall_windows.go

Not many windows users have perl installed. They can just use
standard go tools instead. Also mkerrors_windows.sh script
removed - we don't add any new "unix" errors to windows
syscall package anymore.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/41060044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b