Issue 41057: Messages with "repeated" fields do not compile cleanly with g++ -Weffc++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 41057: Messages with "repeated" fields do not compile cleanly with g++ -Weffc++

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by mdpoole

Modified:
15 years ago

Reviewers:
kenton

Base URL:
http://protobuf.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -47 lines)			Patch
M	src/google/protobuf/compiler/cpp/cpp_enum_field.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/google/protobuf/compiler/cpp/cpp_message.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google/protobuf/compiler/cpp/cpp_message_field.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google/protobuf/compiler/cpp/cpp_primitive_field.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/google/protobuf/compiler/cpp/cpp_string_field.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google/protobuf/descriptor.pb.cc	View	36 chunks	+84 lines, -42 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kenton

15 years ago (2009-04-16 22:43:58 UTC) #2

Looks good to me.  I added a newline between "_unknown_fields_()," and
"_cached_size_(0)" but otherwise submitted verbatim.

Committed as rev 108.

Thanks!

Expand All Messages | Collapse All Messages