Issue 4090044: Make rpc transport OAuth2 an opt in feature

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4090044: Make rpc transport OAuth2 an opt in feature

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by zhoresh

Modified:
13 years, 3 months ago

Reviewers:
johnfargo, Paul Lindner, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

In order to stream line push of new code this feature need to be configurable

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -6 lines)			Patch
		features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js	View		3 chunks	+18 lines, -5 lines	0 comments	Download
		features/src/main/javascript/features/osapi/jsonrpctransport.js	View		2 chunks	+9 lines, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

johnfargo

LGTM++ You can just commit as-is, comment is micro. http://codereview.appspot.com/4090044/diff/1/features/src/main/javascript/features/osapi/jsonrpctransport.js File features/src/main/javascript/features/osapi/jsonrpctransport.js (right): http://codereview.appspot.com/4090044/diff/1/features/src/main/javascript/features/osapi/jsonrpctransport.js#newcode65 features/src/main/javascript/features/osapi/jsonrpctransport.js:65: ...

13 years, 3 months ago (2011-01-26 23:06:30 UTC) #2

Submitted to r1063924

Expand All Messages | Collapse All Messages