Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3261)

Issue 40870046: Add Property Panel to show IME properties. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by fujiwara
Modified:
10 years, 4 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Add Property Panel to show IME properties. Currently GtkStatusIcon can show one icon only while GtkApplet shows multiple icons. IBus GTK Panel icon shows the IBus engine icon however each IBus engine provides the properties and currently it can be show only when users click the panel icon and show the activate menu. Users wish to know the some of the properties without clicking the icon. Property Panel offers a window which shows engine properties' icon at input cursor. It's similar to Language Panel in IBus 1.4. Property Panel is shown in only 3 seconds whenever client applications get focus-in event or any of engine properties are changed, e.g. InputMode is changed from Hiragana to Eisu, in case gsettings panel.show is AUTO_HIDE (by default). Property Panel is always hidden in case panel.show is DO_NOT_SHOW. Property Panel is always shown in case panel.show is ALWAYS. BUG=http://code.google.com/p/ibus/issues/detail?id=1659 TEST=ui/gtk3/ibus-ui-gtk3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -17 lines) Patch
M data/ibus.schemas.in View 2 chunks +14 lines, -2 lines 0 comments Download
M setup/setup.ui View 3 chunks +5 lines, -5 lines 0 comments Download
M src/ibusattrlist.c View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gtk3/Makefile.am View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gtk3/panel.vala View 9 chunks +41 lines, -5 lines 0 comments Download
M ui/gtk3/property.vala View 3 chunks +7 lines, -1 line 0 comments Download
A ui/gtk3/propertypanel.vala View 1 1 chunk +520 lines, -0 lines 0 comments Download

Messages

Total messages: 4
fujiwara
Attached the patch. The previous discussion about another status icon is: https://codereview.appspot.com/9462047/
10 years, 4 months ago (2013-12-12 05:12:31 UTC) #1
Peng
I like this feature. But I do not have env to test it. Could you ...
10 years, 4 months ago (2013-12-13 16:56:40 UTC) #2
fujiwara
> Could you please describe UI behavior in CL description? Done. https://codereview.appspot.com/40870046/diff/1/ui/gtk3/propertypanel.vala File ui/gtk3/propertypanel.vala (right): ...
10 years, 4 months ago (2013-12-16 08:33:56 UTC) #3
Peng
10 years, 4 months ago (2013-12-16 15:29:06 UTC) #4
On 2013/12/16 08:33:56, fujiwara wrote:
> > Could you please describe UI behavior in CL description?
> 
> Done.
> 
> https://codereview.appspot.com/40870046/diff/1/ui/gtk3/propertypanel.vala
> File ui/gtk3/propertypanel.vala (right):
> 
>
https://codereview.appspot.com/40870046/diff/1/ui/gtk3/propertypanel.vala#new...
> ui/gtk3/propertypanel.vala:269: warning("unknown property type %d",
> (int)prop.get_prop_type());
> On 2013/12/13 16:56:40, Peng wrote:
> > 80+ chars?
> 
> Done.
thanks. LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b