Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1495)

Issue 4070043: code review 4070043: http: added virtual host mappings BEFORE default path m...

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by josvazg
Modified:
13 years, 4 months ago
Reviewers:
rsc
CC:
bradfitz, rsc, golang-dev
Visibility:
Public.

Description

http: added virtual host mappings BEFORE default path mappings + reply to fixes asked by rsc at patch6 See http://groups.google.com/group/golang-nuts/browse_thread/thread/872b2c6feb556e62 and http://codereview.appspot.com/4070043

Patch Set 1 #

Total comments: 3

Patch Set 2 : code review 4070043: http: added virtual host mappings BEFORE default path m... #

Total comments: 8

Patch Set 3 : code review 4070043: http: added virtual host mappings BEFORE default path m... #

Patch Set 4 : code review 4070043: http: added virtual host mappings BEFORE default path m... #

Total comments: 8

Patch Set 5 : code review 4070043: http: added virtual host mappings BEFORE default path m... #

Total comments: 2

Patch Set 6 : code review 4070043: http: added virtual host mappings BEFORE default path m... #

Total comments: 4

Patch Set 7 : code review 4070043: http: added virtual host mappings BEFORE default path m... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -21 lines) Patch
M src/pkg/http/serve_test.go View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
M src/pkg/http/server.go View 1 2 3 4 5 chunks +29 lines, -21 lines 0 comments Download

Messages

Total messages: 27
bradfitz
http://codereview.appspot.com/4070043/diff/1/src/pkg/http/server.go File src/pkg/http/server.go (right): http://codereview.appspot.com/4070043/diff/1/src/pkg/http/server.go#newcode533 src/pkg/http/server.go:533: // Patterns must begin with /, excepfor virtual hosts ...
13 years, 4 months ago (2011-01-25 17:57:22 UTC) #1
rsc
please run hg mail to send in code reviews. that will take care of things ...
13 years, 4 months ago (2011-01-25 18:01:21 UTC) #2
josvazg
Ok 1 - fix comments 2 - run gofmt 3 - run hg mail 4 ...
13 years, 4 months ago (2011-01-25 22:49:55 UTC) #3
bradfitzgoog
On Tue, Jan 25, 2011 at 2:49 PM, <josvazg@gmail.com> wrote: > > I will have ...
13 years, 4 months ago (2011-01-26 00:04:39 UTC) #4
josvazg
Hello golang-dev@googlegroups.com, bradfitzgo, rsc, bradfitzwork (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 4 months ago (2011-01-26 15:13:18 UTC) #5
rsc
http://codereview.appspot.com/4070043/diff/4002/src/pkg/http/serve_test.go File src/pkg/http/serve_test.go (right): http://codereview.appspot.com/4070043/diff/4002/src/pkg/http/serve_test.go#newcode10 src/pkg/http/serve_test.go:10: "bytes" sort imports http://codereview.appspot.com/4070043/diff/4002/src/pkg/http/serve_test.go#newcode140 src/pkg/http/serve_test.go:140: rw.Write(([]byte)("Default")) the () around ...
13 years, 4 months ago (2011-01-26 15:29:37 UTC) #6
josvazg
Hello bradfitzgo, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2011-01-26 16:31:50 UTC) #7
josvazg
Hello bradfitzgo, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2011-01-26 16:35:41 UTC) #8
rsc
the code looks good. the test still looks a bit like a Java test instead ...
13 years, 4 months ago (2011-01-26 16:54:25 UTC) #9
josvazg
Can't seem to work at home, hg clpatch seems not supported by my home hg ...
13 years, 4 months ago (2011-01-26 20:07:44 UTC) #10
rsc
On Wed, Jan 26, 2011 at 15:07, <josvazg@gmail.com> wrote: > Can't seem to work at ...
13 years, 4 months ago (2011-01-26 20:25:13 UTC) #11
josvazg
Yes I already tried that: $ cat .hg/hgrc [paths] default = https://go.googlecode.com/hg/ [extensions] codereview = ...
13 years, 4 months ago (2011-01-26 21:02:22 UTC) #12
rsc
On Wed, Jan 26, 2011 at 16:02, <josvazg@gmail.com> wrote: > Yes I already tried that: ...
13 years, 4 months ago (2011-01-26 21:23:02 UTC) #13
josvazg
Thanks a lot! - The path for codereview.py was wrong, I didn't notice. - The ...
13 years, 4 months ago (2011-01-26 21:40:33 UTC) #14
josvazg
Why do I get this error?: $ hg clpatch 4070043 warning: cannot find josvazg@gmail.com in ...
13 years, 4 months ago (2011-01-26 21:41:24 UTC) #15
rsc
On Wed, Jan 26, 2011 at 16:41, <josvazg@gmail.com> wrote: > Why do I get this ...
13 years, 4 months ago (2011-01-26 21:45:54 UTC) #16
josvazg
Hello bradfitzgo, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2011-01-27 15:50:53 UTC) #17
rsc
http://codereview.appspot.com/4070043/diff/1003/src/pkg/http/serve_test.go File src/pkg/http/serve_test.go (right): http://codereview.appspot.com/4070043/diff/1003/src/pkg/http/serve_test.go#newcode204 src/pkg/http/serve_test.go:204: func TestVirtualHostHandlers(t *testing.T) { TestHostPatterns i know that other ...
13 years, 4 months ago (2011-01-27 16:19:54 UTC) #18
josvazg
Hello bradfitzgo, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2011-01-27 17:43:07 UTC) #19
rsc
Very close. Looks like a Go test now. :-) http://codereview.appspot.com/4070043/diff/33001/src/pkg/http/serve_test.go File src/pkg/http/serve_test.go (right): http://codereview.appspot.com/4070043/diff/33001/src/pkg/http/serve_test.go#newcode149 src/pkg/http/serve_test.go:149: ...
13 years, 4 months ago (2011-01-27 17:55:38 UTC) #20
josvazg
Hello bradfitzgo, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2011-01-28 10:38:48 UTC) #21
josvazg
Couldn't work at home again. I fixed my GO building environment so that ./all.bash and ...
13 years, 4 months ago (2011-01-28 10:43:26 UTC) #22
rsc
On Fri, Jan 28, 2011 at 05:43, <josvazg@gmail.com> wrote: > Couldn't work at home again. ...
13 years, 4 months ago (2011-01-28 13:07:28 UTC) #23
rsc
LGTM Thanks for seeing this through. Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright so ...
13 years, 4 months ago (2011-01-28 13:11:01 UTC) #24
josvazg
Done. I guess I should be receiving an answer from Google by post mail? Do ...
13 years, 4 months ago (2011-01-29 10:57:51 UTC) #25
rsc
On Sat, Jan 29, 2011 at 05:57, <josvazg@gmail.com> wrote: > Done. I guess I should ...
13 years, 4 months ago (2011-01-30 17:16:18 UTC) #26
rsc
13 years, 4 months ago (2011-02-01 18:59:02 UTC) #27
*** Submitted as http://code.google.com/p/go/source/detail?r=49c53513a8a2 ***

http: add host patterns

R=bradfitzgo, rsc
CC=golang-dev
http://codereview.appspot.com/4070043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b