Issue 40690046: code review 40690046: crypto/cipher: speed up gcmInc32.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 40690046: code review 40690046: crypto/cipher: speed up gcmInc32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by hanwen-google

Modified:
11 years, 7 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

crypto/cipher: speed up gcmInc32. The counter is not secret, so the code does not need to be constant time. benchmark old MB/s new MB/s speedup BenchmarkAESGCMSeal1K 89.90 92.84 1.03x BenchmarkAESGCMOpen1K 89.16 92.30 1.04x

Patch Set 1 #

Patch Set 2 : diff -r d45af824172f https://code.google.com/p/go #

Patch Set 3 : diff -r d45af824172f https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pkg/crypto/cipher/gcm.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hanwen-google

Hello agl1 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-12-12 10:20:01 UTC) #1

agl1

11 years, 7 months ago (2013-12-12 16:25:36 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=cf1632b6db5e ***

crypto/cipher: speed up gcmInc32.

The counter is not secret, so the code does not need to be
constant time.

benchmark                    old MB/s     new MB/s  speedup
BenchmarkAESGCMSeal1K           89.90        92.84    1.03x
BenchmarkAESGCMOpen1K           89.16        92.30    1.04x

R=agl
CC=golang-dev
https://codereview.appspot.com/40690046

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages