Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 40650048: cmd/juju: alias remove-service and remove-machine

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by jameinel
Modified:
10 years, 4 months ago
Reviewers:
axw, mp+199221, fwereade
Visibility:
Public.

Description

cmd/juju: alias remove-service and remove-machine Part of bug #1261628, this lets us document 'remove-*' as the preferred syntax for operations, since they aren't quite as "scary" as 'destroy-*'. This is targetting 1.16 so that we can start documenting their use (in a stable release). In trunk we could then actually rename the command and have the old name as the alias. (So the command is 'remove-machine' with an alias of 'destroy-machine' for compatibility purposes.) https://code.launchpad.net/~jameinel/juju-core/1.16-remove-service-1261628/+merge/199221 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/destroymachine.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/destroyservice.go View 1 chunk +1 line, -0 lines 0 comments Download
M cmd/juju/main_test.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
jameinel
Please take a look.
10 years, 4 months ago (2013-12-17 06:26:20 UTC) #1
axw
On 2013/12/17 06:26:20, jameinel wrote: > Please take a look. LGTM
10 years, 4 months ago (2013-12-17 07:02:34 UTC) #2
fwereade
10 years, 4 months ago (2013-12-18 15:04:41 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b