Issue 40540049: code review 40540049: crypto/rc4: fix type errors in pure Go implementation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 40540049: code review 40540049: crypto/rc4: fix type errors in pure Go implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by neelance

Modified:
11 years, 7 months ago

Reviewers:
agl1, dave

CC:
golang-dev, agl1

Visibility:
Public.

Description

crypto/rc4: fix type errors in pure Go implementation

Patch Set 1 #

Patch Set 2 : diff -r cf1632b6db5e https://code.google.com/p/go #

Patch Set 3 : diff -r cf1632b6db5e https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/crypto/rc4/rc4_ref.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

neelance

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-12-12 19:17:14 UTC) #1

agl1

*** Submitted as https://code.google.com/p/go/source/detail?r=3895ad0afefe *** crypto/rc4: fix type errors in pure Go implementation R=golang-dev, agl ...

11 years, 7 months ago (2013-12-12 19:32:37 UTC) #3

dave_cheney.net

11 years, 7 months ago (2013-12-13 03:28:09 UTC) #4

I would like to see a test added for this please. 

> On 13 Dec 2013, at 6:32, agl@golang.org wrote:
> 
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=3895ad0afefe ***
> 
> crypto/rc4: fix type errors in pure Go implementation
> 
> R=golang-dev, agl
> CC=golang-dev
> https://codereview.appspot.com/40540049
> 
> Committer: Adam Langley <agl@golang.org>
> 
> 
> https://codereview.appspot.com/40540049/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Expand All Messages | Collapse All Messages