Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(496)

Issue 40410043: code review 40410043: database/sql: Use all connections in pool

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by johto
Modified:
5 years, 1 month ago
Reviewers:
bradfitz
CC:
golang-codereviews, gobot, bradfitz
Visibility:
Public.

Description

database/sql: Use all connections in pool The last connection in the pool was not being handed out correctly.

Patch Set 1 #

Patch Set 2 : diff -r 812d1128f288 https://code.google.com/p/go #

Patch Set 3 : diff -r 812d1128f288 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M src/pkg/database/sql/sql.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5
johto
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
5 years, 2 months ago (2013-12-10 19:27:54 UTC) #1
gobot
R=bradfitz@golang.org (assigned by r@golang.org)
5 years, 2 months ago (2013-12-19 21:24:19 UTC) #2
gobot
Replacing golang-dev with golang-codereviews.
5 years, 2 months ago (2013-12-20 16:26:20 UTC) #3
bradfitz
LGTM
5 years, 1 month ago (2013-12-26 19:27:12 UTC) #4
bradfitz
5 years, 1 month ago (2013-12-26 19:27:27 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=8a7ac002f840 ***

database/sql: Use all connections in pool

The last connection in the pool was not being handed out correctly.

R=golang-codereviews, gobot, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/40410043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b