Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(160)

Issue 40400043: code review 40400043: test: don't rely on order of unrelated imports in bug191 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by iant
Modified:
11 years, 6 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

test: don't rely on order of unrelated imports in bug191 There is no necessary relationship between the imports of the packages a and b, and gccgo happens to import them in a different order, leading to different output. This ordering is not the purpose of the test in any case.

Patch Set 1 #

Patch Set 2 : diff -r c2f2dc4141cf https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M test/fixedbugs/bug191.go View 1 chunk +1 line, -1 line 0 comments Download
R test/fixedbugs/bug191.out View 1 chunk +0 lines, -2 lines 0 comments Download
M test/fixedbugs/bug191.dir/a.go View 1 chunk +3 lines, -1 line 0 comments Download
M test/fixedbugs/bug191.dir/b.go View 1 chunk +3 lines, -1 line 0 comments Download
M test/fixedbugs/bug191.dir/main.go View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 6 months ago (2013-12-10 19:15:51 UTC) #1
rsc
LGTM
11 years, 6 months ago (2013-12-10 19:32:30 UTC) #2
rsc
If we were to define an order, it sure wouldn't be the one the test ...
11 years, 6 months ago (2013-12-10 19:32:44 UTC) #3
iant
11 years, 6 months ago (2013-12-10 20:05:40 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=8da130e8d70f ***

test: don't rely on order of unrelated imports in bug191

There is no necessary relationship between the imports of the
packages a and b, and gccgo happens to import them in a
different order, leading to different output.  This ordering
is not the purpose of the test in any case.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/40400043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b